marko10_000
/
wine-wine
forked from Mirrors/wine-wine
1
0
Fork 0
Code Issues Pull Requests Releases Wiki Activity

winedbg: Support QStartNoAckMode to reduce verbosity. 

We don't have to validate and acknowledge the packets as long as this
mode is enabled, this will reduce verbosity especially when tracing.

Signed-off-by: Rémi Bernon <rbernon@codeweavers.com>
Signed-off-by: Alexandre Julliard <julliard@winehq.org>
feature/deterministic
Rémi Bernon 2020-03-31 15:12:29 +02:00 committed by Alexandre Julliard
parent ec76cb754e
commit 83284dbad4
1 changed files with 21 additions and 11 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

32
programs/winedbg/gdbproxy.c
View File

@ -94,6 +94,7 @@ struct gdb_context
struct dbg_process* process; struct dbg_process* process;
/* Unix environment */ /* Unix environment */
unsigned long wine_segs[3]; /* load addresses of the ELF wine exec segments (text, bss and data) */ unsigned long wine_segs[3]; /* load addresses of the ELF wine exec segments (text, bss and data) */
BOOL no_ack_mode;
}; };
static BOOL tgt_process_gdbproxy_read(HANDLE hProcess, const void* addr, static BOOL tgt_process_gdbproxy_read(HANDLE hProcess, const void* addr,
@ -1614,15 +1615,11 @@ static enum packet_return packet_query(struct gdb_context* gdbctx)
return packet_ok; return packet_ok;
if (strncmp(gdbctx->in_packet, "Supported", 9) == 0) if (strncmp(gdbctx->in_packet, "Supported", 9) == 0)
{ {
if (*target_xml) packet_reply_open(gdbctx);
return packet_reply(gdbctx, "PacketSize=400;qXfer:features:read+"); packet_reply_add(gdbctx, "QStartNoAckMode+;");
else if (*target_xml) packet_reply_add(gdbctx, "PacketSize=400;qXfer:features:read+");
{ packet_reply_close(gdbctx);
/* no features supported */ return packet_done;
packet_reply_open(gdbctx);
packet_reply_close(gdbctx);
return packet_done;
}
} }
break; break;
case 'T': case 'T':
@ -1659,6 +1656,17 @@ static enum packet_return packet_query(struct gdb_context* gdbctx)
return packet_error; return packet_error;
} }
static enum packet_return packet_set(struct gdb_context* gdbctx)
{
if (strncmp(gdbctx->in_packet, "StartNoAckMode", 14) == 0)
{
gdbctx->no_ack_mode = TRUE;
return packet_ok;
}
return packet_error;
}
static enum packet_return packet_step(struct gdb_context* gdbctx) static enum packet_return packet_step(struct gdb_context* gdbctx)
{ {
/* FIXME: add support for address in packet */ /* FIXME: add support for address in packet */
@ -1736,7 +1744,7 @@ static struct packet_entry packet_entries[] =
{'p', packet_read_register}, {'p', packet_read_register},
{'P', packet_write_register}, {'P', packet_write_register},
{'q', packet_query}, {'q', packet_query},
/* {'Q', packet_set}, */ {'Q', packet_set},
/* {'R', packet,restart}, only in extended mode ! */ /* {'R', packet,restart}, only in extended mode ! */
{'s', packet_step}, {'s', packet_step},
/*{'S', packet_step_signal}, hard(er) to implement */ /*{'S', packet_step_signal}, hard(er) to implement */
@ -1757,7 +1765,8 @@ static BOOL extract_packets(struct gdb_context* gdbctx)
* end points to the end of the received data buffer * end points to the end of the received data buffer
*/ */
while ((ptr = memchr(sum, '$', end - sum)) && while (!gdbctx->no_ack_mode &&
(ptr = memchr(sum, '$', end - sum)) &&
(sum = memchr(ptr, '#', end - ptr)) && (sum = memchr(ptr, '#', end - ptr)) &&
(end - sum >= 3) && sscanf(sum, "#%02x", &cksum) == 1) (end - sum >= 3) && sscanf(sum, "#%02x", &cksum) == 1)
{ {
@ -1998,6 +2007,7 @@ static BOOL gdb_init_context(struct gdb_context* gdbctx, unsigned flags, unsigne
gdbctx->last_sig = 0; gdbctx->last_sig = 0;
gdbctx->in_trap = FALSE; gdbctx->in_trap = FALSE;
gdbctx->process = NULL; gdbctx->process = NULL;
gdbctx->no_ack_mode = FALSE;
for (i = 0; i < ARRAY_SIZE(gdbctx->wine_segs); i++) for (i = 0; i < ARRAY_SIZE(gdbctx->wine_segs); i++)
gdbctx->wine_segs[i] = 0; gdbctx->wine_segs[i] = 0;