forked from Mirrors/wine-wine
msi: An empty source is an invalid parameter.
parent
dde89244e5
commit
7fe6aad7fa
|
@ -603,7 +603,7 @@ UINT WINAPI MsiSourceListAddSourceExW( LPCWSTR szProduct, LPCWSTR szUserSid,
|
||||||
if (!szProduct || !squash_guid(szProduct, squished_pc))
|
if (!szProduct || !squash_guid(szProduct, squished_pc))
|
||||||
return ERROR_INVALID_PARAMETER;
|
return ERROR_INVALID_PARAMETER;
|
||||||
|
|
||||||
if (!szSource)
|
if (!szSource || !*szSource)
|
||||||
return ERROR_INVALID_PARAMETER;
|
return ERROR_INVALID_PARAMETER;
|
||||||
|
|
||||||
if (dwOptions & MSICODE_PATCH)
|
if (dwOptions & MSICODE_PATCH)
|
||||||
|
|
|
@ -617,10 +617,7 @@ static void test_MsiSourceListAddSourceEx(void)
|
||||||
r = pMsiSourceListAddSourceExA(prodcode, usersid,
|
r = pMsiSourceListAddSourceExA(prodcode, usersid,
|
||||||
MSIINSTALLCONTEXT_USERUNMANAGED,
|
MSIINSTALLCONTEXT_USERUNMANAGED,
|
||||||
MSISOURCETYPE_URL, "", 1);
|
MSISOURCETYPE_URL, "", 1);
|
||||||
todo_wine
|
ok(r == ERROR_INVALID_PARAMETER, "Expected ERROR_INVALID_PARAMETER, got %d\n", r);
|
||||||
{
|
|
||||||
ok(r == ERROR_INVALID_PARAMETER, "Expected ERROR_INVALID_PARAMETER, got %d\n", r);
|
|
||||||
}
|
|
||||||
|
|
||||||
/* MSIINSTALLCONTEXT_USERMANAGED, non-NULL szUserSid */
|
/* MSIINSTALLCONTEXT_USERMANAGED, non-NULL szUserSid */
|
||||||
|
|
||||||
|
|
Loading…
Reference in New Issue