marko10_000
/
wine-wine
forked from Mirrors/wine-wine
1
0
Fork 0
Code Issues Pull Requests Releases Wiki Activity

dwrite: Use IDWriteFactory7 for gdiinterop. 

Signed-off-by: Nikolay Sivov <nsivov@codeweavers.com>
Signed-off-by: Alexandre Julliard <julliard@winehq.org>
stable
Nikolay Sivov 2019-12-05 11:56:05 +03:00 committed by Alexandre Julliard
parent 7a33f48ed2
commit 5c39a118c4
3 changed files with 93 additions and 81 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

4
dlls/dwrite/dwrite_private.h
View File

@ -269,14 +269,14 @@ extern HRESULT create_fontfacereference(IDWriteFactory7 *factory, IDWriteFontFil
extern HRESULT factory_get_cached_fontface(IDWriteFactory7 *factory, IDWriteFontFile * const *files, UINT32 num_files, extern HRESULT factory_get_cached_fontface(IDWriteFactory7 *factory, IDWriteFontFile * const *files, UINT32 num_files,
DWRITE_FONT_SIMULATIONS simulations, struct list **cache, REFIID riid, void **obj) DECLSPEC_HIDDEN; DWRITE_FONT_SIMULATIONS simulations, struct list **cache, REFIID riid, void **obj) DECLSPEC_HIDDEN;
extern void factory_detach_fontcollection(IDWriteFactory7 *factory, IDWriteFontCollection3 *collection) DECLSPEC_HIDDEN; extern void factory_detach_fontcollection(IDWriteFactory7 *factory, IDWriteFontCollection3 *collection) DECLSPEC_HIDDEN;
extern void factory_detach_gdiinterop(IDWriteFactory5*,IDWriteGdiInterop1*) DECLSPEC_HIDDEN; extern void factory_detach_gdiinterop(IDWriteFactory7 *factory, IDWriteGdiInterop1 *interop) DECLSPEC_HIDDEN;
extern struct fontfacecached *factory_cache_fontface(IDWriteFactory7 *factory, struct list *fontfaces, extern struct fontfacecached *factory_cache_fontface(IDWriteFactory7 *factory, struct list *fontfaces,
IDWriteFontFace5 *fontface) DECLSPEC_HIDDEN; IDWriteFontFace5 *fontface) DECLSPEC_HIDDEN;
extern void get_logfont_from_font(IDWriteFont*,LOGFONTW*) DECLSPEC_HIDDEN; extern void get_logfont_from_font(IDWriteFont*,LOGFONTW*) DECLSPEC_HIDDEN;
extern void get_logfont_from_fontface(IDWriteFontFace*,LOGFONTW*) DECLSPEC_HIDDEN; extern void get_logfont_from_fontface(IDWriteFontFace*,LOGFONTW*) DECLSPEC_HIDDEN;
extern HRESULT get_fontsig_from_font(IDWriteFont*,FONTSIGNATURE*) DECLSPEC_HIDDEN; extern HRESULT get_fontsig_from_font(IDWriteFont*,FONTSIGNATURE*) DECLSPEC_HIDDEN;
extern HRESULT get_fontsig_from_fontface(IDWriteFontFace*,FONTSIGNATURE*) DECLSPEC_HIDDEN; extern HRESULT get_fontsig_from_fontface(IDWriteFontFace*,FONTSIGNATURE*) DECLSPEC_HIDDEN;
extern HRESULT create_gdiinterop(IDWriteFactory5*,IDWriteGdiInterop1**) DECLSPEC_HIDDEN; extern HRESULT create_gdiinterop(IDWriteFactory7 *factory, IDWriteGdiInterop1 **interop) DECLSPEC_HIDDEN;
extern void fontface_detach_from_cache(IDWriteFontFace5 *fontface) DECLSPEC_HIDDEN; extern void fontface_detach_from_cache(IDWriteFontFace5 *fontface) DECLSPEC_HIDDEN;
extern void factory_lock(IDWriteFactory7 *factory) DECLSPEC_HIDDEN; extern void factory_lock(IDWriteFactory7 *factory) DECLSPEC_HIDDEN;
extern void factory_unlock(IDWriteFactory7 *factory) DECLSPEC_HIDDEN; extern void factory_unlock(IDWriteFactory7 *factory) DECLSPEC_HIDDEN;

162
dlls/dwrite/gdiinterop.c
View File

@ -38,12 +38,13 @@ struct dib_data {
int width; int width;
}; };
struct rendertarget { struct rendertarget
{
IDWriteBitmapRenderTarget1 IDWriteBitmapRenderTarget1_iface; IDWriteBitmapRenderTarget1 IDWriteBitmapRenderTarget1_iface;
ID2D1SimplifiedGeometrySink ID2D1SimplifiedGeometrySink_iface; ID2D1SimplifiedGeometrySink ID2D1SimplifiedGeometrySink_iface;
LONG ref; LONG refcount;
IDWriteFactory5 *factory; IDWriteFactory7 *factory;
DWRITE_TEXT_ANTIALIAS_MODE antialiasmode; DWRITE_TEXT_ANTIALIAS_MODE antialiasmode;
FLOAT ppdip; FLOAT ppdip;
DWRITE_MATRIX m; DWRITE_MATRIX m;
@ -52,11 +53,12 @@ struct rendertarget {
struct dib_data dib; struct dib_data dib;
}; };
struct gdiinterop { struct gdiinterop
{
IDWriteGdiInterop1 IDWriteGdiInterop1_iface; IDWriteGdiInterop1 IDWriteGdiInterop1_iface;
IDWriteFontFileLoader IDWriteFontFileLoader_iface; IDWriteFontFileLoader IDWriteFontFileLoader_iface;
LONG ref; LONG refcount;
IDWriteFactory5 *factory; IDWriteFactory7 *factory;
}; };
struct memresource_stream { struct memresource_stream {
@ -249,27 +251,29 @@ static HRESULT WINAPI rendertarget_QueryInterface(IDWriteBitmapRenderTarget1 *if
static ULONG WINAPI rendertarget_AddRef(IDWriteBitmapRenderTarget1 *iface) static ULONG WINAPI rendertarget_AddRef(IDWriteBitmapRenderTarget1 *iface)
{ {
struct rendertarget *This = impl_from_IDWriteBitmapRenderTarget1(iface); struct rendertarget *target = impl_from_IDWriteBitmapRenderTarget1(iface);
ULONG ref = InterlockedIncrement(&This->ref); ULONG refcount = InterlockedIncrement(&target->refcount);
TRACE("(%p)->(%d)\n", This, ref);
return ref; TRACE("%p, refcount %u.\n", iface, refcount);
return refcount;
} }
static ULONG WINAPI rendertarget_Release(IDWriteBitmapRenderTarget1 *iface) static ULONG WINAPI rendertarget_Release(IDWriteBitmapRenderTarget1 *iface)
{ {
struct rendertarget *This = impl_from_IDWriteBitmapRenderTarget1(iface); struct rendertarget *target = impl_from_IDWriteBitmapRenderTarget1(iface);
ULONG ref = InterlockedDecrement(&This->ref); ULONG refcount = InterlockedDecrement(&target->refcount);
TRACE("(%p)->(%d)\n", This, ref); TRACE("%p, refcount %u.\n", iface, refcount);
if (!ref) if (!refcount)
{ {
IDWriteFactory5_Release(This->factory); IDWriteFactory7_Release(target->factory);
DeleteDC(This->hdc); DeleteDC(target->hdc);
heap_free(This); heap_free(target);
} }
return ref; return refcount;
} }
static inline DWORD *get_pixel_ptr_32(struct dib_data *dib, int x, int y) static inline DWORD *get_pixel_ptr_32(struct dib_data *dib, int x, int y)
@ -341,22 +345,22 @@ static HRESULT WINAPI rendertarget_DrawGlyphRun(IDWriteBitmapRenderTarget1 *ifac
DWRITE_GLYPH_RUN const *run, IDWriteRenderingParams *params, COLORREF color, DWRITE_GLYPH_RUN const *run, IDWriteRenderingParams *params, COLORREF color,
RECT *bbox_ret) RECT *bbox_ret)
{ {
struct rendertarget *This = impl_from_IDWriteBitmapRenderTarget1(iface); struct rendertarget *target = impl_from_IDWriteBitmapRenderTarget1(iface);
IDWriteGlyphRunAnalysis *analysis; IDWriteGlyphRunAnalysis *analysis;
DWRITE_RENDERING_MODE1 rendermode; DWRITE_RENDERING_MODE1 rendermode;
DWRITE_GRID_FIT_MODE gridfitmode; DWRITE_GRID_FIT_MODE gridfitmode;
DWRITE_TEXTURE_TYPE texturetype; DWRITE_TEXTURE_TYPE texturetype;
DWRITE_GLYPH_RUN scaled_run; DWRITE_GLYPH_RUN scaled_run;
IDWriteFontFace3 *fontface; IDWriteFontFace3 *fontface;
RECT target, bounds; RECT target_rect, bounds;
HRESULT hr; HRESULT hr;
TRACE("(%p)->(%.2f %.2f %d %p %p 0x%08x %p)\n", This, originX, originY, TRACE("%p, %.8e, %.8e, %d, %p, %p, 0x%08x, %p.\n", iface, originX, originY,
measuring_mode, run, params, color, bbox_ret); measuring_mode, run, params, color, bbox_ret);
SetRectEmpty(bbox_ret); SetRectEmpty(bbox_ret);
if (!This->dib.ptr) if (!target->dib.ptr)
return S_OK; return S_OK;
if (!params) if (!params)
@ -367,18 +371,19 @@ static HRESULT WINAPI rendertarget_DrawGlyphRun(IDWriteBitmapRenderTarget1 *ifac
return hr; return hr;
} }
hr = IDWriteFontFace3_GetRecommendedRenderingMode(fontface, run->fontEmSize, This->ppdip * 96.0f, hr = IDWriteFontFace3_GetRecommendedRenderingMode(fontface, run->fontEmSize, target->ppdip * 96.0f,
This->ppdip * 96.0f, NULL /* FIXME */, run->isSideways, DWRITE_OUTLINE_THRESHOLD_ALIASED, measuring_mode, target->ppdip * 96.0f, NULL /* FIXME */, run->isSideways, DWRITE_OUTLINE_THRESHOLD_ALIASED, measuring_mode,
params, &rendermode, &gridfitmode); params, &rendermode, &gridfitmode);
IDWriteFontFace3_Release(fontface); IDWriteFontFace3_Release(fontface);
if (FAILED(hr)) if (FAILED(hr))
return hr; return hr;
SetRect(&target, 0, 0, This->size.cx, This->size.cy); SetRect(&target_rect, 0, 0, target->size.cx, target->size.cy);
if (rendermode == DWRITE_RENDERING_MODE1_OUTLINE) { if (rendermode == DWRITE_RENDERING_MODE1_OUTLINE)
{
static const XFORM identity = { 1.0f, 0.0f, 0.0f, 1.0f, 0.0f, 0.0f }; static const XFORM identity = { 1.0f, 0.0f, 0.0f, 1.0f, 0.0f, 0.0f };
const DWRITE_MATRIX *m = &This->m; const DWRITE_MATRIX *m = &target->m;
XFORM xform; XFORM xform;
/* target allows any transform to be set, filter it here */ /* target allows any transform to be set, filter it here */
@ -397,40 +402,42 @@ static HRESULT WINAPI rendertarget_DrawGlyphRun(IDWriteBitmapRenderTarget1 *ifac
xform.eDx = m->m11 * originX + m->m21 * originY + m->dx; xform.eDx = m->m11 * originX + m->m21 * originY + m->dx;
xform.eDy = m->m12 * originX + m->m22 * originY + m->dy; xform.eDy = m->m12 * originX + m->m22 * originY + m->dy;
} }
SetWorldTransform(This->hdc, &xform); SetWorldTransform(target->hdc, &xform);
BeginPath(This->hdc); BeginPath(target->hdc);
hr = IDWriteFontFace_GetGlyphRunOutline(run->fontFace, run->fontEmSize * This->ppdip, hr = IDWriteFontFace_GetGlyphRunOutline(run->fontFace, run->fontEmSize * target->ppdip,
run->glyphIndices, run->glyphAdvances, run->glyphOffsets, run->glyphCount, run->glyphIndices, run->glyphAdvances, run->glyphOffsets, run->glyphCount,
run->isSideways, run->bidiLevel & 1, &This->ID2D1SimplifiedGeometrySink_iface); run->isSideways, run->bidiLevel & 1, &target->ID2D1SimplifiedGeometrySink_iface);
EndPath(This->hdc); EndPath(target->hdc);
if (hr == S_OK) { if (hr == S_OK)
{
HBRUSH brush = CreateSolidBrush(color); HBRUSH brush = CreateSolidBrush(color);
SelectObject(This->hdc, brush); SelectObject(target->hdc, brush);
FillPath(This->hdc); FillPath(target->hdc);
/* FIXME: one way to get affected rectangle bounds is to use region fill */ /* FIXME: one way to get affected rectangle bounds is to use region fill */
if (bbox_ret) if (bbox_ret)
*bbox_ret = target; *bbox_ret = target_rect;
DeleteObject(brush); DeleteObject(brush);
} }
SetWorldTransform(This->hdc, &identity); SetWorldTransform(target->hdc, &identity);
return hr; return hr;
} }
scaled_run = *run; scaled_run = *run;
scaled_run.fontEmSize *= This->ppdip; scaled_run.fontEmSize *= target->ppdip;
hr = IDWriteFactory5_CreateGlyphRunAnalysis(This->factory, &scaled_run, &This->m, rendermode, measuring_mode, hr = IDWriteFactory7_CreateGlyphRunAnalysis(target->factory, &scaled_run, &target->m, rendermode, measuring_mode,
gridfitmode, This->antialiasmode, originX, originY, &analysis); gridfitmode, target->antialiasmode, originX, originY, &analysis);
if (FAILED(hr)) { if (FAILED(hr))
{
WARN("failed to create analysis instance, 0x%08x\n", hr); WARN("failed to create analysis instance, 0x%08x\n", hr);
return hr; return hr;
} }
@ -448,8 +455,9 @@ static HRESULT WINAPI rendertarget_DrawGlyphRun(IDWriteBitmapRenderTarget1 *ifac
texturetype = DWRITE_TEXTURE_CLEARTYPE_3x1; texturetype = DWRITE_TEXTURE_CLEARTYPE_3x1;
} }
if (IntersectRect(&target, &target, &bounds)) { if (IntersectRect(&target_rect, &target_rect, &bounds))
UINT32 size = (target.right - target.left) * (target.bottom - target.top); {
UINT32 size = (target_rect.right - target_rect.left) * (target_rect.bottom - target_rect.top);
BYTE *bitmap; BYTE *bitmap;
color = colorref_to_pixel_888(color); color = colorref_to_pixel_888(color);
@ -461,15 +469,15 @@ static HRESULT WINAPI rendertarget_DrawGlyphRun(IDWriteBitmapRenderTarget1 *ifac
return E_OUTOFMEMORY; return E_OUTOFMEMORY;
} }
hr = IDWriteGlyphRunAnalysis_CreateAlphaTexture(analysis, texturetype, &target, bitmap, size); hr = IDWriteGlyphRunAnalysis_CreateAlphaTexture(analysis, texturetype, &target_rect, bitmap, size);
if (hr == S_OK) { if (hr == S_OK) {
/* blit to target dib */ /* blit to target dib */
if (texturetype == DWRITE_TEXTURE_ALIASED_1x1) if (texturetype == DWRITE_TEXTURE_ALIASED_1x1)
blit_8(&This->dib, bitmap, &target, color); blit_8(&target->dib, bitmap, &target_rect, color);
else else
blit_subpixel_888(&This->dib, This->size.cx, bitmap, &target, color); blit_subpixel_888(&target->dib, target->size.cx, bitmap, &target_rect, color);
if (bbox_ret) *bbox_ret = target; if (bbox_ret) *bbox_ret = target_rect;
} }
heap_free(bitmap); heap_free(bitmap);
@ -584,7 +592,7 @@ static const IDWriteBitmapRenderTarget1Vtbl rendertargetvtbl = {
rendertarget_SetTextAntialiasMode rendertarget_SetTextAntialiasMode
}; };
static HRESULT create_rendertarget(IDWriteFactory5 *factory, HDC hdc, UINT32 width, UINT32 height, IDWriteBitmapRenderTarget **ret) static HRESULT create_rendertarget(IDWriteFactory7 *factory, HDC hdc, UINT32 width, UINT32 height, IDWriteBitmapRenderTarget **ret)
{ {
struct rendertarget *target; struct rendertarget *target;
HRESULT hr; HRESULT hr;
@ -596,7 +604,7 @@ static HRESULT create_rendertarget(IDWriteFactory5 *factory, HDC hdc, UINT32 wid
target->IDWriteBitmapRenderTarget1_iface.lpVtbl = &rendertargetvtbl; target->IDWriteBitmapRenderTarget1_iface.lpVtbl = &rendertargetvtbl;
target->ID2D1SimplifiedGeometrySink_iface.lpVtbl = &rendertargetsinkvtbl; target->ID2D1SimplifiedGeometrySink_iface.lpVtbl = &rendertargetsinkvtbl;
target->ref = 1; target->refcount = 1;
target->hdc = CreateCompatibleDC(hdc); target->hdc = CreateCompatibleDC(hdc);
SetGraphicsMode(target->hdc, GM_ADVANCED); SetGraphicsMode(target->hdc, GM_ADVANCED);
@ -610,7 +618,7 @@ static HRESULT create_rendertarget(IDWriteFactory5 *factory, HDC hdc, UINT32 wid
target->ppdip = GetDeviceCaps(target->hdc, LOGPIXELSX) / 96.0f; target->ppdip = GetDeviceCaps(target->hdc, LOGPIXELSX) / 96.0f;
target->antialiasmode = DWRITE_TEXT_ANTIALIAS_MODE_CLEARTYPE; target->antialiasmode = DWRITE_TEXT_ANTIALIAS_MODE_CLEARTYPE;
target->factory = factory; target->factory = factory;
IDWriteFactory5_AddRef(factory); IDWriteFactory7_AddRef(factory);
*ret = (IDWriteBitmapRenderTarget*)&target->IDWriteBitmapRenderTarget1_iface; *ret = (IDWriteBitmapRenderTarget*)&target->IDWriteBitmapRenderTarget1_iface;
@ -640,26 +648,29 @@ static HRESULT WINAPI gdiinterop_QueryInterface(IDWriteGdiInterop1 *iface, REFII
static ULONG WINAPI gdiinterop_AddRef(IDWriteGdiInterop1 *iface) static ULONG WINAPI gdiinterop_AddRef(IDWriteGdiInterop1 *iface)
{ {
struct gdiinterop *This = impl_from_IDWriteGdiInterop1(iface); struct gdiinterop *interop = impl_from_IDWriteGdiInterop1(iface);
LONG ref = InterlockedIncrement(&This->ref); LONG refcount = InterlockedIncrement(&interop->refcount);
TRACE("(%p)->(%d)\n", This, ref);
return ref; TRACE("%p, refcount %u.\n", iface, refcount);
return refcount;
} }
static ULONG WINAPI gdiinterop_Release(IDWriteGdiInterop1 *iface) static ULONG WINAPI gdiinterop_Release(IDWriteGdiInterop1 *iface)
{ {
struct gdiinterop *This = impl_from_IDWriteGdiInterop1(iface); struct gdiinterop *interop = impl_from_IDWriteGdiInterop1(iface);
LONG ref = InterlockedDecrement(&This->ref); LONG refcount = InterlockedDecrement(&interop->refcount);
TRACE("(%p)->(%d)\n", This, ref); TRACE("%p, refcount %u.\n", iface, refcount);
if (!ref) { if (!refcount)
IDWriteFactory5_UnregisterFontFileLoader(This->factory, &This->IDWriteFontFileLoader_iface); {
factory_detach_gdiinterop(This->factory, iface); IDWriteFactory7_UnregisterFontFileLoader(interop->factory, &interop->IDWriteFontFileLoader_iface);
heap_free(This); factory_detach_gdiinterop(interop->factory, iface);
heap_free(interop);
} }
return ref; return refcount;
} }
static HRESULT WINAPI gdiinterop_CreateFontFromLOGFONT(IDWriteGdiInterop1 *iface, static HRESULT WINAPI gdiinterop_CreateFontFromLOGFONT(IDWriteGdiInterop1 *iface,
@ -751,7 +762,7 @@ extern BOOL WINAPI GetFontFileData(DWORD instance_id, DWORD unknown, UINT64 offs
static HRESULT WINAPI gdiinterop_CreateFontFaceFromHdc(IDWriteGdiInterop1 *iface, static HRESULT WINAPI gdiinterop_CreateFontFaceFromHdc(IDWriteGdiInterop1 *iface,
HDC hdc, IDWriteFontFace **fontface) HDC hdc, IDWriteFontFace **fontface)
{ {
struct gdiinterop *This = impl_from_IDWriteGdiInterop1(iface); struct gdiinterop *interop = impl_from_IDWriteGdiInterop1(iface);
struct font_realization_info info; struct font_realization_info info;
struct font_fileinfo *fileinfo; struct font_fileinfo *fileinfo;
DWRITE_FONT_FILE_TYPE filetype; DWRITE_FONT_FILE_TYPE filetype;
@ -762,7 +773,7 @@ static HRESULT WINAPI gdiinterop_CreateFontFaceFromHdc(IDWriteGdiInterop1 *iface
SIZE_T needed; SIZE_T needed;
HRESULT hr; HRESULT hr;
TRACE("(%p)->(%p %p)\n", This, hdc, fontface); TRACE("%p, %p, %p.\n", iface, hdc, fontface);
*fontface = NULL; *fontface = NULL;
@ -793,10 +804,10 @@ static HRESULT WINAPI gdiinterop_CreateFontFaceFromHdc(IDWriteGdiInterop1 *iface
} }
if (*fileinfo->path) if (*fileinfo->path)
hr = IDWriteFactory5_CreateFontFileReference(This->factory, fileinfo->path, &fileinfo->writetime, &file); hr = IDWriteFactory7_CreateFontFileReference(interop->factory, fileinfo->path, &fileinfo->writetime, &file);
else else
hr = IDWriteFactory5_CreateCustomFontFileReference(This->factory, &info.instance_id, sizeof(info.instance_id), hr = IDWriteFactory7_CreateCustomFontFileReference(interop->factory, &info.instance_id,
&This->IDWriteFontFileLoader_iface, &file); sizeof(info.instance_id), &interop->IDWriteFontFileLoader_iface, &file);
heap_free(fileinfo); heap_free(fileinfo);
if (FAILED(hr)) if (FAILED(hr))
@ -807,7 +818,7 @@ static HRESULT WINAPI gdiinterop_CreateFontFaceFromHdc(IDWriteGdiInterop1 *iface
if (SUCCEEDED(hr)) { if (SUCCEEDED(hr)) {
if (is_supported) if (is_supported)
/* Simulations flags values match DWRITE_FONT_SIMULATIONS */ /* Simulations flags values match DWRITE_FONT_SIMULATIONS */
hr = IDWriteFactory5_CreateFontFace(This->factory, facetype, 1, &file, info.face_index, hr = IDWriteFactory7_CreateFontFace(interop->factory, facetype, 1, &file, info.face_index,
info.simulations, fontface); info.simulations, fontface);
else else
hr = DWRITE_E_FILEFORMAT; hr = DWRITE_E_FILEFORMAT;
@ -828,14 +839,14 @@ static HRESULT WINAPI gdiinterop_CreateBitmapRenderTarget(IDWriteGdiInterop1 *if
static HRESULT WINAPI gdiinterop1_CreateFontFromLOGFONT(IDWriteGdiInterop1 *iface, static HRESULT WINAPI gdiinterop1_CreateFontFromLOGFONT(IDWriteGdiInterop1 *iface,
LOGFONTW const *logfont, IDWriteFontCollection *collection, IDWriteFont **font) LOGFONTW const *logfont, IDWriteFontCollection *collection, IDWriteFont **font)
{ {
struct gdiinterop *This = impl_from_IDWriteGdiInterop1(iface); struct gdiinterop *interop = impl_from_IDWriteGdiInterop1(iface);
IDWriteFontFamily *family; IDWriteFontFamily *family;
DWRITE_FONT_STYLE style; DWRITE_FONT_STYLE style;
BOOL exists = FALSE; BOOL exists = FALSE;
UINT32 index; UINT32 index;
HRESULT hr; HRESULT hr;
TRACE("(%p)->(%p %p %p)\n", This, logfont, collection, font); TRACE("%p, %p, %p, %p.\n", iface, logfont, collection, font);
*font = NULL; *font = NULL;
@ -844,7 +855,7 @@ static HRESULT WINAPI gdiinterop1_CreateFontFromLOGFONT(IDWriteGdiInterop1 *ifac
if (collection) if (collection)
IDWriteFontCollection_AddRef(collection); IDWriteFontCollection_AddRef(collection);
else { else {
hr = IDWriteFactory5_GetSystemFontCollection(This->factory, FALSE, (IDWriteFontCollection1**)&collection, FALSE); hr = IDWriteFactory5_GetSystemFontCollection((IDWriteFactory5 *)interop->factory, FALSE, (IDWriteFontCollection1 **)&collection, FALSE);
if (FAILED(hr)) { if (FAILED(hr)) {
ERR("failed to get system font collection: 0x%08x.\n", hr); ERR("failed to get system font collection: 0x%08x.\n", hr);
return hr; return hr;
@ -1089,7 +1100,7 @@ static const struct IDWriteFontFileLoaderVtbl memresourceloadervtbl = {
memresourceloader_CreateStreamFromKey, memresourceloader_CreateStreamFromKey,
}; };
HRESULT create_gdiinterop(IDWriteFactory5 *factory, IDWriteGdiInterop1 **ret) HRESULT create_gdiinterop(IDWriteFactory7 *factory, IDWriteGdiInterop1 **ret)
{ {
struct gdiinterop *interop; struct gdiinterop *interop;
@ -1100,9 +1111,10 @@ HRESULT create_gdiinterop(IDWriteFactory5 *factory, IDWriteGdiInterop1 **ret)
interop->IDWriteGdiInterop1_iface.lpVtbl = &gdiinteropvtbl; interop->IDWriteGdiInterop1_iface.lpVtbl = &gdiinteropvtbl;
interop->IDWriteFontFileLoader_iface.lpVtbl = &memresourceloadervtbl; interop->IDWriteFontFileLoader_iface.lpVtbl = &memresourceloadervtbl;
interop->ref = 1; interop->refcount = 1;
IDWriteFactory5_AddRef(interop->factory = factory); interop->factory = factory;
IDWriteFactory5_RegisterFontFileLoader(factory, &interop->IDWriteFontFileLoader_iface); IDWriteFactory7_AddRef(interop->factory);
IDWriteFactory7_RegisterFontFileLoader(factory, &interop->IDWriteFontFileLoader_iface);
*ret = &interop->IDWriteGdiInterop1_iface; *ret = &interop->IDWriteGdiInterop1_iface;
return S_OK; return S_OK;

8
dlls/dwrite/main.c
View File

@ -1157,7 +1157,7 @@ static HRESULT WINAPI dwritefactory_GetGdiInterop(IDWriteFactory7 *iface, IDWrit
if (factory->gdiinterop) if (factory->gdiinterop)
IDWriteGdiInterop1_AddRef(factory->gdiinterop); IDWriteGdiInterop1_AddRef(factory->gdiinterop);
else else
hr = create_gdiinterop((IDWriteFactory5 *)iface, &factory->gdiinterop); hr = create_gdiinterop(iface, &factory->gdiinterop);
*gdi_interop = (IDWriteGdiInterop *)factory->gdiinterop; *gdi_interop = (IDWriteGdiInterop *)factory->gdiinterop;
@ -1893,11 +1893,11 @@ void factory_detach_fontcollection(IDWriteFactory7 *iface, IDWriteFontCollection
IDWriteFactory7_Release(iface); IDWriteFactory7_Release(iface);
} }
void factory_detach_gdiinterop(IDWriteFactory5 *iface, IDWriteGdiInterop1 *interop) void factory_detach_gdiinterop(IDWriteFactory7 *iface, IDWriteGdiInterop1 *interop)
{ {
struct dwritefactory *factory = impl_from_IDWriteFactory7((IDWriteFactory7 *)iface); struct dwritefactory *factory = impl_from_IDWriteFactory7(iface);
factory->gdiinterop = NULL; factory->gdiinterop = NULL;
IDWriteFactory5_Release(iface); IDWriteFactory7_Release(iface);
} }
HRESULT WINAPI DWriteCreateFactory(DWRITE_FACTORY_TYPE type, REFIID riid, IUnknown **ret) HRESULT WINAPI DWriteCreateFactory(DWRITE_FACTORY_TYPE type, REFIID riid, IUnknown **ret)