marko10_000
/
openclonk
forked from Mirrors/openclonk
1
0
Fork 0
Code Issues Pull Requests Releases Wiki Activity

Goal controller: Readability 

The change in call structure should not make that much of a difference in performance.
directional-lights
Mark 2016-10-09 11:18:10 +02:00
parent 0d22f58b52
commit b18a7b7a3f
1 changed files with 6 additions and 2 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

8
planet/Objects.ocd/HUD.ocd/Controller.ocd/ControllerGoal.ocd/Script.c
View File

@ -113,14 +113,18 @@ public func OnGoalUpdate(object goal)
return _inherited(goal, ...);
}
// Get current goal display settings
var goal_picture_def = goal->~GetPictureDefinition() ?? goal->GetID();
var goal_picture = goal->~GetPictureName() ?? goal->GetGraphics();
var goal_short_description = goal->~GetShortDescription(GetOwner());
var update_req = goal_gui_menu.Symbol != goal_picture_def;
// Determine changes
var update_symbol = goal_gui_menu.Symbol != goal_picture_def;
var update_graphics = goal_gui_menu.GraphicsName != goal_picture;
var update_text = goal_gui_menu.text.Text != goal_short_description;
// Only update if something has changed.
if (update_req || goal_gui_menu.GraphicsName != goal_picture || goal_gui_menu.text.Text != goal_short_description)
if (update_symbol || update_graphics || update_text)
{
goal_gui_menu.text.Text = goal_short_description;
goal_gui_menu.Symbol = goal_picture_def;