Go to file
Byongho Lee 9a99d2b683 btrfs-progs: fix memory leak in btrfs-convert main()
In btrfs-convert main(), strdup() allocates memory to fslabel but that
memory is not freed. We could fix it by adding free() calls to every
return point, but that would make the code messy because there are
several return paths.
So I fix it by changing the code using strdup() with local array and
strncpy().

And btrfs-convert main() guarantees that string length of fslabel is not
to exceed 'BTRFS_LABEL_SIZE', so it's enough to use strcpy() instead of
strncpy() to copy fslabel in do_convert().

Signed-off-by: Byongho Lee <bhlee.kernel@gmail.com>
Signed-off-by: David Sterba <dsterba@suse.com>
2015-09-01 14:02:48 +02:00
Documentation btrfs-progs: doc: update qgroup docs 2015-08-31 19:25:11 +02:00
tests btrfs-progs: tests: umount TEST_MNT in clean-tests.sh 2015-09-01 14:02:48 +02:00
.gitignore btrfs-progs: update .gitignore 2015-06-02 17:16:47 +02:00
COPYING fix COPYING 2007-06-12 15:41:08 -04:00
INSTALL btrfs-progs: INSTALL: fix typos 2015-06-22 01:39:27 +02:00
Makefile.in btrfs-progs: do not install static binaries over non-static 2015-08-31 19:25:11 +02:00
autogen.sh btrfs-progs: build, make autogen.sh work on older systems 2015-01-28 19:03:23 +01:00
backref.c btrfs-progs: read_tree_block() and read_node_slot() cleanup. 2015-02-02 19:21:24 +01:00
backref.h btrfs-progs: unify header file inclusion protections 2015-01-21 17:49:26 +01:00
bcp Btrfs-progs: Correct path munging in bcp 2011-10-25 09:18:58 -04:00
bitops.h btrfs-progs: compat: define DIV_ROUND_UP if not already defined 2015-06-05 23:29:59 +02:00
btrfs-calc-size.c Btrfs-progs: fix compile warnings 2015-04-14 15:11:24 +02:00
btrfs-completion btrfs-progs: inspect: add command min-dev-size 2015-08-31 19:25:08 +02:00
btrfs-convert.c btrfs-progs: fix memory leak in btrfs-convert main() 2015-09-01 14:02:48 +02:00
btrfs-corrupt-block.c btrfs-progs: add newline to some error messages 2015-08-31 19:25:13 +02:00
btrfs-crc.c btrfs-progs: use check_argc_* to check arg number for all tools 2014-08-22 15:07:02 +02:00
btrfs-debug-tree.c btrfs-progs: accept --help as option in the standalone utilities 2015-06-11 00:23:30 +02:00
btrfs-debugfs btrfs-progs: Add simple python front end to the search ioctl 2014-12-04 17:03:49 +01:00
btrfs-find-root.c btrfs-progs: find-root: Output matched root when searching all roots 2015-08-31 19:25:13 +02:00
btrfs-fragments.c btrfs-progs: drop feature defines from C files, in favour of CFLAGS defines 2015-01-27 14:45:59 +01:00
btrfs-image.c btrfs-progs: Use existing facility to replace read_data_extent function 2015-08-31 19:25:13 +02:00
btrfs-list.c btrfs-progs: fix memory leaks in error path 2015-08-31 19:25:12 +02:00
btrfs-list.h btrfs-progs: add missing includes to header files 2015-06-10 02:52:21 +02:00
btrfs-map-logical.c btrfs-progs: fix memory leak in btrfs-map-logical main() 2015-08-31 19:25:14 +02:00
btrfs-select-super.c btrfs-progs: autoconf: use standard PACKAGE_* macros 2015-01-28 18:00:58 +01:00
btrfs-show-super.c btrfs-progs: show-super: print human readable text for super flags 2015-05-14 15:41:07 +02:00
btrfs-zero-log.c btrfs-progs: cleanup and deprecate btrfs-zero-log 2015-06-05 18:02:08 +02:00
btrfs.c btrfs-progs: print compact help for btrfs 2015-06-09 14:27:54 +02:00
btrfsck.h btrfs-progs: add missing includes to header files 2015-06-10 02:52:21 +02:00
btrfstune.c btrfs-progs: btrfstune: print correct current uuid during rewrite 2015-06-18 19:49:44 +02:00
chunk-recover.c Btrfs-progs: skip opening all devices with restore 2015-02-09 14:53:15 -05:00
cmds-balance.c btrfs-progs: add command group info strings 2015-06-09 14:26:33 +02:00
cmds-check.c btrfs-progs: add newline to some error messages 2015-08-31 19:25:13 +02:00
cmds-device.c btrfs-progs: Use common unit parser for btrfs device command 2015-09-01 14:01:59 +02:00
cmds-fi-usage.c btrfs-progs: Use common unit parser for btrfs filesystem command 2015-09-01 14:02:48 +02:00
cmds-fi-usage.h btrfs-progs: add missing includes to header files 2015-06-10 02:52:21 +02:00
cmds-filesystem.c btrfs-progs: Use common unit parser for btrfs filesystem command 2015-09-01 14:02:48 +02:00
cmds-inspect.c btrfs-progs: compilation errors when using musl libc 2015-08-31 19:25:11 +02:00
cmds-property.c btrfs-progs: prop: use macro terminator for command list 2015-08-31 19:25:09 +02:00
cmds-qgroup.c btrfs-progs: Use common unit parser for btrfs qgroup command 2015-09-01 14:01:59 +02:00
cmds-quota.c btrfs-progs: add command group info strings 2015-06-09 14:26:33 +02:00
cmds-receive.c btrfs-progs: compilation errors when using musl libc 2015-08-31 19:25:11 +02:00
cmds-replace.c btrfs-progs: fix use after free in replace start 2015-08-31 19:25:13 +02:00
cmds-rescue.c btrfs-progs: unify naming of command handlers 2015-08-31 19:25:09 +02:00
cmds-restore.c btrfs-progs: restore: add more long option variants 2015-05-14 15:41:06 +02:00
cmds-scrub.c btrfs-progs: fix memory leaks in error path 2015-08-31 19:25:12 +02:00
cmds-send.c btrfs-progs: add newline to some error messages 2015-08-31 19:25:13 +02:00
cmds-subvolume.c btrfs-progs: remove code for setup mntid in cmd_subvol_show 2015-08-31 19:25:14 +02:00
commands.h btrfs-progs: alias btrfs device delete to btrfs device remove 2015-06-26 16:33:39 +02:00
configure.ac btrfs-progs: configure: fix typo in summary 2015-06-22 01:13:48 +02:00
crc32c.c btrfs-progs: make many private symbols static 2013-09-03 19:41:08 +02:00
crc32c.h btrfs-progs: libify some parts of btrfs-progs 2013-02-27 15:24:25 +01:00
ctree.c btrfs-progs: check for item end outside of leaf 2015-07-01 15:20:23 +02:00
ctree.h btrfs-progs: convert: Avoid allocating metadata extent crossing stripe boundary 2015-08-31 19:25:10 +02:00
dir-item.c btrfs-progs: add newline to some error messages 2015-08-31 19:25:13 +02:00
dir-test.c Btrfs-progs: fix magic return value in dir-test.c 2013-10-16 08:20:42 -04:00
disk-io.c btrfs-progs: Avoid reading bad fd in case of missing device. 2015-08-31 19:25:12 +02:00
disk-io.h btrfs-progs: export read_extent_data function 2015-06-17 16:08:35 +02:00
extent-cache.c btrfs-progs: Add last_cache_extent() for extent-cache. 2014-12-10 11:54:10 +01:00
extent-cache.h btrfs-progs: unify header file inclusion protections 2015-01-21 17:49:26 +01:00
extent-tree.c btrfs-progs: convert: Avoid allocating metadata extent crossing stripe boundary 2015-08-31 19:25:10 +02:00
extent_io.c btrfs-progs: Avoid reading bad fd in case of missing device. 2015-08-31 19:25:12 +02:00
extent_io.h btrfs-progs: Move (set/clear_)extent_buffer_uptodate() to extent_io.h. 2015-02-27 17:44:11 +01:00
file-item.c btrfs-progs: remove btrfs_release_path before btrfs_free_path 2014-09-14 19:06:12 +02:00
file.c btrfs-progs: Add btrfs_get_extent() and btrfs_punch_hole(). 2015-02-02 14:16:38 +01:00
find-root.c btrfs-progs: find-root: fix a bug that will cause wrong result 2015-08-31 19:25:13 +02:00
find-root.h btrfs-progs: Add new find-root.[ch] infrastructure 2015-02-11 18:34:04 +01:00
free-space-cache.c btrfs-progs: add newline to some error messages 2015-08-31 19:25:13 +02:00
free-space-cache.h btrfs-progs: add missing includes to header files 2015-06-10 02:52:21 +02:00
fsck.btrfs btrfs-progs: fsck.btrfs: Fix bashism and bad getopts processing 2015-05-21 16:53:44 +02:00
hash.h btrfs-progs: unify header file inclusion protections 2015-01-21 17:49:26 +01:00
hasher.c Unaligned access fixes 2008-02-15 11:19:58 -05:00
help.c btrfs-progs: no extra newline between aliased commands in help text 2015-06-26 16:44:29 +02:00
inode-item.c btrfs-progs: fix overflow check in btrfs_insert_inode_ref 2014-12-30 15:48:55 +01:00
inode-map.c btrfs-progs: remove btrfs_release_path before btrfs_free_path 2014-09-14 19:06:12 +02:00
inode.c btrfs-progs: handle orphan creation error in btrfs_unlink 2015-01-06 18:46:03 +01:00
ioctl-test.c btrfs-progs: mark static & remove unused from non-kernel code 2013-09-03 19:40:54 +02:00
ioctl.h btrfs-progs: add missing includes to header files 2015-06-10 02:52:21 +02:00
kerncompat.h btrfs-progs: compilation errors when using musl libc 2015-08-31 19:25:11 +02:00
library-test.c btrfs-progs: build, add basic build test for library 2014-11-07 17:52:57 +01:00
list.h Btrfs-progs: introduce list_{first, next}_entry/list_splice_tail{_init} 2013-07-03 14:06:55 -04:00
list_sort.c btrfs-progs: add list_sort and use it to sort devices by id 2013-10-16 08:22:26 -04:00
list_sort.h btrfs-progs: add list_sort and use it to sort devices by id 2013-10-16 08:22:26 -04:00
mkfs.c btrfs-progs: add newline to some error messages 2015-08-31 19:25:13 +02:00
print-tree.c btrfs-progs: print-tree: print stripe len of a chunk 2015-08-31 19:25:09 +02:00
print-tree.h btrfs-progs: unify header file inclusion protections 2015-01-21 17:49:26 +01:00
props.c btrfs-progs: Introduce change_header_uuid function 2015-05-14 15:41:07 +02:00
props.h btrfs-progs: unify header file inclusion protections 2015-01-21 17:49:26 +01:00
qgroup-verify.c btrfs-progs: read_tree_block() and read_node_slot() cleanup. 2015-02-02 19:21:24 +01:00
qgroup-verify.h btrfs-progs: add missing includes to header files 2015-06-10 02:52:21 +02:00
qgroup.c btrfs-progs: fix memory leaks in error path 2015-08-31 19:25:12 +02:00
qgroup.h btrfs-progs: add missing includes to header files 2015-06-10 02:52:21 +02:00
quick-test.c Btrfs-progs: rework open_ctree to take flags, add a new one V2 2013-11-07 16:10:40 -05:00
radix-tree.c btrfs-progs: Remove a unused function root_gtp_mask(). 2014-12-19 15:04:56 +01:00
radix-tree.h btrfs-progs: libify some parts of btrfs-progs 2013-02-27 15:24:25 +01:00
raid6.c btrfs-progs: give raid6.c its exported prototypes 2013-09-03 19:41:11 +02:00
random-test.c Btrfs-progs: fix magic return value in random-test.c 2013-10-16 08:20:42 -04:00
rbtree-utils.c Btrfs-progs: break out rbtree util functions 2014-10-14 10:39:39 +02:00
rbtree-utils.h btrfs-progs: libbtrfs, make exported headers compatible with C++ 2014-11-03 23:50:50 +01:00
rbtree.c Btrfs-progs: update rbtree libs 2014-10-14 10:39:40 +02:00
rbtree.h btrfs-progs: libbtrfs, make exported headers compatible with C++ 2014-11-03 23:50:50 +01:00
rbtree_augmented.h btrfs-progs: libbtrfs, make exported headers compatible with C++ 2014-11-03 23:50:50 +01:00
repair.c Btrfs-progs: introduce common insert/search/delete functions for rb-tree 2013-07-03 14:06:54 -04:00
repair.h btrfs-progs: add missing includes to header files 2015-06-10 02:52:21 +02:00
root-tree.c Btrfs-progs: free path if we don't find root item 2014-03-21 06:23:32 -07:00
send-stream.c btrfs-progs: fix compiler warning 2014-11-07 18:14:38 +01:00
send-stream.h btrfs-progs: add missing includes to header files 2015-06-10 02:52:21 +02:00
send-test.c btrfs-progs: drop feature defines from C files, in favour of CFLAGS defines 2015-01-27 14:45:59 +01:00
send-utils.c btrfs-progs: drop argument from attribute deprecated 2015-06-30 15:05:07 +02:00
send-utils.h btrfs-progs: drop argument from attribute deprecated 2015-06-30 15:05:07 +02:00
send.h btrfs-progs: unify header file inclusion protections 2015-01-21 17:49:26 +01:00
show-blocks Fix showblocks to display different colors for different metadata roots 2009-03-09 13:00:44 -04:00
string-table.c btrfs-progs: Add helpers functions to handle the printing of data in tabular format 2014-12-04 16:48:09 +01:00
string-table.h btrfs-progs: unify header file inclusion protections 2015-01-21 17:49:26 +01:00
super-recover.c Btrfs-progs: skip opening all devices with restore 2015-02-09 14:53:15 -05:00
task-utils.c btrfs-progs: Set info->periodic.timer_fd to 0 in init-fail 2015-08-31 19:25:10 +02:00
task-utils.h btrfs-progs: unify header file inclusion protections 2015-01-21 17:49:26 +01:00
transaction.h btrfs-progs: add missing includes to header files 2015-06-10 02:52:21 +02:00
ulist.c btrfs-progs: import ulist 2014-08-22 14:39:33 +02:00
ulist.h btrfs-progs: unify header file inclusion protections 2015-01-21 17:49:26 +01:00
utils-lib.c btrfs-progs: drop feature defines from C files, in favour of CFLAGS defines 2015-01-27 14:45:59 +01:00
utils.c btrfs-progs: Introduce get_unit_mode_from_arg for common use 2015-08-31 19:25:14 +02:00
utils.h btrfs-progs: Introduce get_unit_mode_from_arg for common use 2015-08-31 19:25:14 +02:00
uuid-tree.c btrfs-progs: fix in-place byte swapping 2013-09-03 19:41:06 +02:00
version.h.in btrfs-progs: re-introduce BTRFS_BUILD_VERSION in version.h 2015-03-16 18:40:06 +01:00
version.sh Btrfs progs v4.1.2 2015-07-14 13:45:36 +02:00
volumes.c btrfs-progs: Introduce btrfs_close_all_devices helper 2015-08-31 19:25:13 +02:00
volumes.h btrfs-progs: Introduce btrfs_close_all_devices helper 2015-08-31 19:25:13 +02:00