forked from Mirrors/btrfs-progs
555b7feaeb
This change adds code to detect and fix the issue introduced in the kernel
release 3.17, where creation of read-only snapshots lead to a corrupted
filesystem if they were created at a moment when the source subvolume/snapshot
had orphan items. The issue was that the on-disk root items became incorrect,
referring to the pre orphan cleanup root node instead of the post orphan
cleanup root node.
A test filesystem can be generated with the test case recently submitted for
xfstests/fstests, which is essencially the following (bash script):
workout()
{
ops=$1
procs=$2
num_snapshots=$3
_scratch_mkfs >> $seqres.full 2>&1
_scratch_mount
snapshot_cmd="$BTRFS_UTIL_PROG subvolume snapshot -r $SCRATCH_MNT"
snapshot_cmd="$snapshot_cmd $SCRATCH_MNT/snap_\`date +'%H_%M_%S_%N'\`"
run_check $FSSTRESS_PROG -p $procs \
-x "$snapshot_cmd" -X $num_snapshots -d $SCRATCH_MNT -n $ops
}
ops=10000
procs=4
snapshots=500
workout $ops $procs $snapshots
Example of btrfsck's (btrfs check) behaviour against such filesystem:
$ btrfsck /dev/loop0
root item for root 311, current bytenr 44630016, current gen 60, current level 1, new bytenr 44957696, new gen 61, new level 1
root item for root 1480, current bytenr 1003569152, current gen 1271, current level 1, new bytenr 1004175360, new gen 1272, new level 1
root item for root 1509, current bytenr 1037434880, current gen 1300, current level 1, new bytenr 1038467072, new gen 1301, new level 1
root item for root 1562, current bytenr 33636352, current gen 1354, current level 1, new bytenr 34455552, new gen 1355, new level 1
root item for root 3094, current bytenr 1011712000, current gen 2935, current level 1, new bytenr 1008484352, new gen 2936, new level 1
root item for root 3716, current bytenr 80805888, current gen 3578, current level 1, new bytenr 73515008, new gen 3579, new level 1
root item for root 4085, current bytenr 714031104, current gen 3958, current level 1, new bytenr 716816384, new gen 3959, new level 1
Found 7 roots with an outdated root item.
Please run a filesystem check with the option --repair to fix them.
$ echo $?
1
$ btrfsck --repair /dev/loop0
enabling repair mode
fixing root item for root 311, current bytenr 44630016, current gen 60, current level 1, new bytenr 44957696, new gen 61, new level 1
fixing root item for root 1480, current bytenr 1003569152, current gen 1271, current level 1, new bytenr 1004175360, new gen 1272, new level 1
fixing root item for root 1509, current bytenr 1037434880, current gen 1300, current level 1, new bytenr 1038467072, new gen 1301, new level 1
fixing root item for root 1562, current bytenr 33636352, current gen 1354, current level 1, new bytenr 34455552, new gen 1355, new level 1
fixing root item for root 3094, current bytenr 1011712000, current gen 2935, current level 1, new bytenr 1008484352, new gen 2936, new level 1
fixing root item for root 3716, current bytenr 80805888, current gen 3578, current level 1, new bytenr 73515008, new gen 3579, new level 1
fixing root item for root 4085, current bytenr 714031104, current gen 3958, current level 1, new bytenr 716816384, new gen 3959, new level 1
Fixed 7 roots.
Checking filesystem on /dev/loop0
UUID: 2186e9b9-c977-4a35-9c7b-69c6609d4620
checking extents
checking free space cache
cache and super generation don't match, space cache will be invalidated
checking fs roots
checking csums
checking root refs
found 618537000 bytes used err is 0
total csum bytes: 130824
total tree bytes: 601620480
total fs tree bytes: 580288512
total extent tree bytes: 18464768
btree space waste bytes: 136939144
file data blocks allocated: 34150318080
referenced 27815415808
Btrfs v3.17-rc3-2-gbbe1dd8
$ echo $?
0
Signed-off-by: Filipe Manana <fdmanana@suse.com>
Signed-off-by: David Sterba <dsterba@suse.cz>
|
||
|---|---|---|
| Documentation | ||
| tests | ||
| .gitignore | ||
| COPYING | ||
| INSTALL | ||
| Makefile | ||
| backref.c | ||
| backref.h | ||
| bcp | ||
| bitops.h | ||
| btrfs-calc-size.c | ||
| btrfs-convert.c | ||
| btrfs-corrupt-block.c | ||
| btrfs-crc.c | ||
| btrfs-debug-tree.c | ||
| btrfs-find-root.c | ||
| btrfs-fragments.c | ||
| btrfs-image.c | ||
| btrfs-list.c | ||
| btrfs-list.h | ||
| btrfs-map-logical.c | ||
| btrfs-select-super.c | ||
| btrfs-show-super.c | ||
| btrfs-zero-log.c | ||
| btrfs.c | ||
| btrfsck.h | ||
| btrfstune.c | ||
| chunk-recover.c | ||
| cmds-balance.c | ||
| cmds-check.c | ||
| cmds-device.c | ||
| cmds-filesystem.c | ||
| cmds-inspect.c | ||
| cmds-property.c | ||
| cmds-qgroup.c | ||
| cmds-quota.c | ||
| cmds-receive.c | ||
| cmds-replace.c | ||
| cmds-rescue.c | ||
| cmds-restore.c | ||
| cmds-scrub.c | ||
| cmds-send.c | ||
| cmds-subvolume.c | ||
| commands.h | ||
| crc32c.c | ||
| crc32c.h | ||
| ctree.c | ||
| ctree.h | ||
| dir-item.c | ||
| dir-test.c | ||
| disk-io.c | ||
| disk-io.h | ||
| extent-cache.c | ||
| extent-cache.h | ||
| extent-tree.c | ||
| extent_io.c | ||
| extent_io.h | ||
| file-item.c | ||
| free-space-cache.c | ||
| free-space-cache.h | ||
| fsck.btrfs | ||
| hash.h | ||
| hasher.c | ||
| help.c | ||
| inode-item.c | ||
| inode-map.c | ||
| ioctl-test.c | ||
| ioctl.h | ||
| kerncompat.h | ||
| list.h | ||
| list_sort.c | ||
| list_sort.h | ||
| math.h | ||
| mkfs.c | ||
| print-tree.c | ||
| print-tree.h | ||
| props.c | ||
| props.h | ||
| qgroup-verify.c | ||
| qgroup-verify.h | ||
| qgroup.c | ||
| qgroup.h | ||
| quick-test.c | ||
| radix-tree.c | ||
| radix-tree.h | ||
| raid6.c | ||
| random-test.c | ||
| rbtree-utils.c | ||
| rbtree-utils.h | ||
| rbtree.c | ||
| rbtree.h | ||
| rbtree_augmented.h | ||
| repair.c | ||
| repair.h | ||
| root-tree.c | ||
| send-stream.c | ||
| send-stream.h | ||
| send-test.c | ||
| send-utils.c | ||
| send-utils.h | ||
| send.h | ||
| show-blocks | ||
| super-recover.c | ||
| transaction.h | ||
| ulist.c | ||
| ulist.h | ||
| utils-lib.c | ||
| utils.c | ||
| utils.h | ||
| uuid-tree.c | ||
| version.sh | ||
| volumes.c | ||
| volumes.h | ||