forked from Mirrors/btrfs-progs
btrfs-progs: cleanup, kill trivial btrfs_set_key_type helper
Signed-off-by: David Sterba <dsterba@suse.com>master
parent
ea84d54121
commit
555743075b
|
@ -990,7 +990,7 @@ int btrfs_find_one_extref(struct btrfs_root *root, u64 inode_objectid,
|
||||||
unsigned long ptr;
|
unsigned long ptr;
|
||||||
|
|
||||||
key.objectid = inode_objectid;
|
key.objectid = inode_objectid;
|
||||||
btrfs_set_key_type(&key, BTRFS_INODE_EXTREF_KEY);
|
key.type = BTRFS_INODE_EXTREF_KEY;
|
||||||
key.offset = start_off;
|
key.offset = start_off;
|
||||||
|
|
||||||
ret = btrfs_search_slot(NULL, root, &key, path, 0, 0);
|
ret = btrfs_search_slot(NULL, root, &key, path, 0, 0);
|
||||||
|
|
|
@ -2739,7 +2739,7 @@ static int do_rollback(const char *devname)
|
||||||
|
|
||||||
key.objectid = objectid;
|
key.objectid = objectid;
|
||||||
key.offset = 0;
|
key.offset = 0;
|
||||||
btrfs_set_key_type(&key, BTRFS_EXTENT_DATA_KEY);
|
key.type = BTRFS_EXTENT_DATA_KEY;
|
||||||
ret = btrfs_search_slot(NULL, image_root, &key, &path, 0, 0);
|
ret = btrfs_search_slot(NULL, image_root, &key, &path, 0, 0);
|
||||||
if (ret != 0) {
|
if (ret != 0) {
|
||||||
error("unable to find first file extent: %d", ret);
|
error("unable to find first file extent: %d", ret);
|
||||||
|
|
|
@ -8509,7 +8509,7 @@ again:
|
||||||
btrfs_init_path(&path);
|
btrfs_init_path(&path);
|
||||||
key.offset = 0;
|
key.offset = 0;
|
||||||
key.objectid = 0;
|
key.objectid = 0;
|
||||||
btrfs_set_key_type(&key, BTRFS_ROOT_ITEM_KEY);
|
key.type = BTRFS_ROOT_ITEM_KEY;
|
||||||
ret = btrfs_search_slot(NULL, root->fs_info->tree_root,
|
ret = btrfs_search_slot(NULL, root->fs_info->tree_root,
|
||||||
&key, &path, 0, 0);
|
&key, &path, 0, 0);
|
||||||
if (ret < 0)
|
if (ret < 0)
|
||||||
|
@ -9207,7 +9207,7 @@ static int check_extent_data_backref(struct btrfs_fs_info *fs_info,
|
||||||
btrfs_release_path(&path);
|
btrfs_release_path(&path);
|
||||||
}
|
}
|
||||||
key.objectid = root_id;
|
key.objectid = root_id;
|
||||||
btrfs_set_key_type(&key, BTRFS_ROOT_ITEM_KEY);
|
key.type = BTRFS_ROOT_ITEM_KEY;
|
||||||
key.offset = (u64)-1;
|
key.offset = (u64)-1;
|
||||||
btrfs_init_path(&path);
|
btrfs_init_path(&path);
|
||||||
|
|
||||||
|
|
|
@ -388,7 +388,7 @@ again:
|
||||||
|
|
||||||
key.offset = 0;
|
key.offset = 0;
|
||||||
key.objectid = 0;
|
key.objectid = 0;
|
||||||
btrfs_set_key_type(&key, BTRFS_ROOT_ITEM_KEY);
|
key.type = BTRFS_ROOT_ITEM_KEY;
|
||||||
ret = btrfs_search_slot(NULL, tree_root_scan, &key, &path, 0, 0);
|
ret = btrfs_search_slot(NULL, tree_root_scan, &key, &path, 0, 0);
|
||||||
if (ret < 0) {
|
if (ret < 0) {
|
||||||
error("cannot read ROOT_ITEM from tree %llu: %s",
|
error("cannot read ROOT_ITEM from tree %llu: %s",
|
||||||
|
|
5
ctree.h
5
ctree.h
|
@ -1840,11 +1840,6 @@ static inline u8 btrfs_key_type(struct btrfs_key *key)
|
||||||
return key->type;
|
return key->type;
|
||||||
}
|
}
|
||||||
|
|
||||||
static inline void btrfs_set_key_type(struct btrfs_key *key, u8 val)
|
|
||||||
{
|
|
||||||
key->type = val;
|
|
||||||
}
|
|
||||||
|
|
||||||
/* struct btrfs_header */
|
/* struct btrfs_header */
|
||||||
BTRFS_SETGET_HEADER_FUNCS(header_bytenr, struct btrfs_header, bytenr, 64);
|
BTRFS_SETGET_HEADER_FUNCS(header_bytenr, struct btrfs_header, bytenr, 64);
|
||||||
BTRFS_SETGET_HEADER_FUNCS(header_generation, struct btrfs_header,
|
BTRFS_SETGET_HEADER_FUNCS(header_generation, struct btrfs_header,
|
||||||
|
|
|
@ -75,7 +75,7 @@ int btrfs_insert_xattr_item(struct btrfs_trans_handle *trans,
|
||||||
u32 data_size;
|
u32 data_size;
|
||||||
|
|
||||||
key.objectid = dir;
|
key.objectid = dir;
|
||||||
btrfs_set_key_type(&key, BTRFS_XATTR_ITEM_KEY);
|
key.type = BTRFS_XATTR_ITEM_KEY;
|
||||||
key.offset = btrfs_name_hash(name, name_len);
|
key.offset = btrfs_name_hash(name, name_len);
|
||||||
path = btrfs_alloc_path();
|
path = btrfs_alloc_path();
|
||||||
if (!path)
|
if (!path)
|
||||||
|
@ -125,7 +125,7 @@ int btrfs_insert_dir_item(struct btrfs_trans_handle *trans, struct btrfs_root
|
||||||
u32 data_size;
|
u32 data_size;
|
||||||
|
|
||||||
key.objectid = dir;
|
key.objectid = dir;
|
||||||
btrfs_set_key_type(&key, BTRFS_DIR_ITEM_KEY);
|
key.type = BTRFS_DIR_ITEM_KEY;
|
||||||
key.offset = btrfs_name_hash(name, name_len);
|
key.offset = btrfs_name_hash(name, name_len);
|
||||||
path = btrfs_alloc_path();
|
path = btrfs_alloc_path();
|
||||||
if (!path)
|
if (!path)
|
||||||
|
@ -156,7 +156,7 @@ int btrfs_insert_dir_item(struct btrfs_trans_handle *trans, struct btrfs_root
|
||||||
}
|
}
|
||||||
btrfs_release_path(path);
|
btrfs_release_path(path);
|
||||||
|
|
||||||
btrfs_set_key_type(&key, BTRFS_DIR_INDEX_KEY);
|
key.type = BTRFS_DIR_INDEX_KEY;
|
||||||
key.offset = index;
|
key.offset = index;
|
||||||
dir_item = insert_with_overflow(trans, root, path, &key, data_size,
|
dir_item = insert_with_overflow(trans, root, path, &key, data_size,
|
||||||
name, name_len);
|
name, name_len);
|
||||||
|
@ -196,7 +196,7 @@ struct btrfs_dir_item *btrfs_lookup_dir_item(struct btrfs_trans_handle *trans,
|
||||||
struct extent_buffer *leaf;
|
struct extent_buffer *leaf;
|
||||||
|
|
||||||
key.objectid = dir;
|
key.objectid = dir;
|
||||||
btrfs_set_key_type(&key, BTRFS_DIR_ITEM_KEY);
|
key.type = BTRFS_DIR_ITEM_KEY;
|
||||||
|
|
||||||
key.offset = btrfs_name_hash(name, name_len);
|
key.offset = btrfs_name_hash(name, name_len);
|
||||||
|
|
||||||
|
|
|
@ -87,7 +87,7 @@ static int ins_one(struct btrfs_trans_handle *trans, struct btrfs_root *root,
|
||||||
|
|
||||||
inode_map.objectid = objectid;
|
inode_map.objectid = objectid;
|
||||||
inode_map.flags = 0;
|
inode_map.flags = 0;
|
||||||
btrfs_set_key_type(&inode_map, BTRFS_INODE_ITEM_KEY);
|
inode_map.type = BTRFS_INODE_ITEM_KEY;
|
||||||
inode_map.offset = 0;
|
inode_map.offset = 0;
|
||||||
|
|
||||||
initial_inode_init(root, &inode_item);
|
initial_inode_init(root, &inode_item);
|
||||||
|
@ -158,7 +158,7 @@ static int insert_dup(struct btrfs_trans_handle *trans, struct btrfs_root
|
||||||
|
|
||||||
key.objectid = file_oid;
|
key.objectid = file_oid;
|
||||||
key.flags = 0;
|
key.flags = 0;
|
||||||
btrfs_set_key_type(&key, BTRFS_INODE_ITEM_KEY);
|
key.type = BTRFS_INODE_ITEM_KEY;
|
||||||
key.offset = 0;
|
key.offset = 0;
|
||||||
ret = btrfs_insert_dir_item(trans, root, buf, strlen(buf), dir_oid,
|
ret = btrfs_insert_dir_item(trans, root, buf, strlen(buf), dir_oid,
|
||||||
&key, BTRFS_FT_UNKNOWN);
|
&key, BTRFS_FT_UNKNOWN);
|
||||||
|
@ -312,7 +312,7 @@ static int empty_tree(struct btrfs_trans_handle *trans, struct btrfs_root
|
||||||
|
|
||||||
key.offset = (u64)-1;
|
key.offset = (u64)-1;
|
||||||
key.flags = 0;
|
key.flags = 0;
|
||||||
btrfs_set_key_type(&key, BTRFS_DIR_ITEM_KEY);
|
key.type = BTRFS_DIR_ITEM_KEY;
|
||||||
key.objectid = dir_oid;
|
key.objectid = dir_oid;
|
||||||
while(nr-- >= 0) {
|
while(nr-- >= 0) {
|
||||||
btrfs_init_path(&path);
|
btrfs_init_path(&path);
|
||||||
|
|
|
@ -2538,7 +2538,7 @@ static int noinline find_free_extent(struct btrfs_trans_handle *trans,
|
||||||
int wrapped = 0;
|
int wrapped = 0;
|
||||||
|
|
||||||
WARN_ON(num_bytes < root->sectorsize);
|
WARN_ON(num_bytes < root->sectorsize);
|
||||||
btrfs_set_key_type(ins, BTRFS_EXTENT_ITEM_KEY);
|
ins->type = BTRFS_EXTENT_ITEM_KEY;
|
||||||
|
|
||||||
search_start = stripe_align(root, search_start);
|
search_start = stripe_align(root, search_start);
|
||||||
|
|
||||||
|
@ -3231,7 +3231,7 @@ int btrfs_read_block_groups(struct btrfs_root *root)
|
||||||
root = info->extent_root;
|
root = info->extent_root;
|
||||||
key.objectid = 0;
|
key.objectid = 0;
|
||||||
key.offset = 0;
|
key.offset = 0;
|
||||||
btrfs_set_key_type(&key, BTRFS_BLOCK_GROUP_ITEM_KEY);
|
key.type = BTRFS_BLOCK_GROUP_ITEM_KEY;
|
||||||
path = btrfs_alloc_path();
|
path = btrfs_alloc_path();
|
||||||
if (!path)
|
if (!path)
|
||||||
return -ENOMEM;
|
return -ENOMEM;
|
||||||
|
@ -3313,7 +3313,7 @@ btrfs_add_block_group(struct btrfs_fs_info *fs_info, u64 bytes_used, u64 type,
|
||||||
cache->key.objectid = chunk_offset;
|
cache->key.objectid = chunk_offset;
|
||||||
cache->key.offset = size;
|
cache->key.offset = size;
|
||||||
|
|
||||||
btrfs_set_key_type(&cache->key, BTRFS_BLOCK_GROUP_ITEM_KEY);
|
cache->key.type = BTRFS_BLOCK_GROUP_ITEM_KEY;
|
||||||
btrfs_set_block_group_used(&cache->item, bytes_used);
|
btrfs_set_block_group_used(&cache->item, bytes_used);
|
||||||
btrfs_set_block_group_chunk_objectid(&cache->item, chunk_objectid);
|
btrfs_set_block_group_chunk_objectid(&cache->item, chunk_objectid);
|
||||||
cache->flags = type;
|
cache->flags = type;
|
||||||
|
@ -3425,7 +3425,7 @@ int btrfs_make_block_groups(struct btrfs_trans_handle *trans,
|
||||||
|
|
||||||
cache->key.objectid = cur_start;
|
cache->key.objectid = cur_start;
|
||||||
cache->key.offset = group_size;
|
cache->key.offset = group_size;
|
||||||
btrfs_set_key_type(&cache->key, BTRFS_BLOCK_GROUP_ITEM_KEY);
|
cache->key.type = BTRFS_BLOCK_GROUP_ITEM_KEY;
|
||||||
|
|
||||||
btrfs_set_block_group_used(&cache->item, 0);
|
btrfs_set_block_group_used(&cache->item, 0);
|
||||||
btrfs_set_block_group_chunk_objectid(&cache->item,
|
btrfs_set_block_group_chunk_objectid(&cache->item,
|
||||||
|
@ -3869,7 +3869,7 @@ int btrfs_fix_block_accounting(struct btrfs_trans_handle *trans,
|
||||||
btrfs_init_path(&path);
|
btrfs_init_path(&path);
|
||||||
key.offset = 0;
|
key.offset = 0;
|
||||||
key.objectid = 0;
|
key.objectid = 0;
|
||||||
btrfs_set_key_type(&key, BTRFS_EXTENT_ITEM_KEY);
|
key.type = BTRFS_EXTENT_ITEM_KEY;
|
||||||
ret = btrfs_search_slot(trans, root->fs_info->extent_root,
|
ret = btrfs_search_slot(trans, root->fs_info->extent_root,
|
||||||
&key, &path, 0, 0);
|
&key, &path, 0, 0);
|
||||||
if (ret < 0)
|
if (ret < 0)
|
||||||
|
@ -4061,7 +4061,7 @@ static int __btrfs_record_file_extent(struct btrfs_trans_handle *trans,
|
||||||
btrfs_release_path(path);
|
btrfs_release_path(path);
|
||||||
ins_key.objectid = objectid;
|
ins_key.objectid = objectid;
|
||||||
ins_key.offset = file_pos;
|
ins_key.offset = file_pos;
|
||||||
btrfs_set_key_type(&ins_key, BTRFS_EXTENT_DATA_KEY);
|
ins_key.type = BTRFS_EXTENT_DATA_KEY;
|
||||||
ret = btrfs_insert_empty_item(trans, root, path, &ins_key,
|
ret = btrfs_insert_empty_item(trans, root, path, &ins_key,
|
||||||
sizeof(*fi));
|
sizeof(*fi));
|
||||||
if (ret)
|
if (ret)
|
||||||
|
|
|
@ -47,7 +47,7 @@ int btrfs_insert_file_extent(struct btrfs_trans_handle *trans,
|
||||||
|
|
||||||
file_key.objectid = objectid;
|
file_key.objectid = objectid;
|
||||||
file_key.offset = pos;
|
file_key.offset = pos;
|
||||||
btrfs_set_key_type(&file_key, BTRFS_EXTENT_DATA_KEY);
|
file_key.type = BTRFS_EXTENT_DATA_KEY;
|
||||||
|
|
||||||
ret = btrfs_insert_empty_item(trans, root, path, &file_key,
|
ret = btrfs_insert_empty_item(trans, root, path, &file_key,
|
||||||
sizeof(*item));
|
sizeof(*item));
|
||||||
|
@ -92,7 +92,7 @@ int btrfs_insert_inline_extent(struct btrfs_trans_handle *trans,
|
||||||
|
|
||||||
key.objectid = objectid;
|
key.objectid = objectid;
|
||||||
key.offset = offset;
|
key.offset = offset;
|
||||||
btrfs_set_key_type(&key, BTRFS_EXTENT_DATA_KEY);
|
key.type = BTRFS_EXTENT_DATA_KEY;
|
||||||
|
|
||||||
datasize = btrfs_file_extent_calc_inline_size(size);
|
datasize = btrfs_file_extent_calc_inline_size(size);
|
||||||
ret = btrfs_insert_empty_item(trans, root, path, &key, datasize);
|
ret = btrfs_insert_empty_item(trans, root, path, &key, datasize);
|
||||||
|
@ -137,7 +137,7 @@ btrfs_lookup_csum(struct btrfs_trans_handle *trans,
|
||||||
|
|
||||||
file_key.objectid = BTRFS_EXTENT_CSUM_OBJECTID;
|
file_key.objectid = BTRFS_EXTENT_CSUM_OBJECTID;
|
||||||
file_key.offset = bytenr;
|
file_key.offset = bytenr;
|
||||||
btrfs_set_key_type(&file_key, BTRFS_EXTENT_CSUM_KEY);
|
file_key.type = BTRFS_EXTENT_CSUM_KEY;
|
||||||
ret = btrfs_search_slot(trans, root, &file_key, path, 0, cow);
|
ret = btrfs_search_slot(trans, root, &file_key, path, 0, cow);
|
||||||
if (ret < 0)
|
if (ret < 0)
|
||||||
goto fail;
|
goto fail;
|
||||||
|
|
|
@ -64,7 +64,7 @@ int btrfs_insert_inode_ref(struct btrfs_trans_handle *trans,
|
||||||
|
|
||||||
key.objectid = inode_objectid;
|
key.objectid = inode_objectid;
|
||||||
key.offset = ref_objectid;
|
key.offset = ref_objectid;
|
||||||
btrfs_set_key_type(&key, BTRFS_INODE_REF_KEY);
|
key.type = BTRFS_INODE_REF_KEY;
|
||||||
|
|
||||||
path = btrfs_alloc_path();
|
path = btrfs_alloc_path();
|
||||||
if (!path)
|
if (!path)
|
||||||
|
|
6
mkfs.c
6
mkfs.c
|
@ -415,7 +415,7 @@ static int add_directory_items(struct btrfs_trans_handle *trans,
|
||||||
|
|
||||||
location.objectid = objectid;
|
location.objectid = objectid;
|
||||||
location.offset = 0;
|
location.offset = 0;
|
||||||
btrfs_set_key_type(&location, BTRFS_INODE_ITEM_KEY);
|
location.type = BTRFS_INODE_ITEM_KEY;
|
||||||
|
|
||||||
if (S_ISDIR(st->st_mode))
|
if (S_ISDIR(st->st_mode))
|
||||||
filetype = BTRFS_FT_DIR;
|
filetype = BTRFS_FT_DIR;
|
||||||
|
@ -554,7 +554,7 @@ static int add_inode_items(struct btrfs_trans_handle *trans,
|
||||||
|
|
||||||
inode_key.objectid = objectid;
|
inode_key.objectid = objectid;
|
||||||
inode_key.offset = 0;
|
inode_key.offset = 0;
|
||||||
btrfs_set_key_type(&inode_key, BTRFS_INODE_ITEM_KEY);
|
inode_key.type = BTRFS_INODE_ITEM_KEY;
|
||||||
|
|
||||||
ret = btrfs_insert_inode(trans, root, objectid, &btrfs_inode);
|
ret = btrfs_insert_inode(trans, root, objectid, &btrfs_inode);
|
||||||
|
|
||||||
|
@ -835,7 +835,7 @@ static int traverse_directory(struct btrfs_trans_handle *trans,
|
||||||
|
|
||||||
root_dir_key.objectid = btrfs_root_dirid(&root->root_item);
|
root_dir_key.objectid = btrfs_root_dirid(&root->root_item);
|
||||||
root_dir_key.offset = 0;
|
root_dir_key.offset = 0;
|
||||||
btrfs_set_key_type(&root_dir_key, BTRFS_INODE_ITEM_KEY);
|
root_dir_key.type = BTRFS_INODE_ITEM_KEY;
|
||||||
ret = btrfs_lookup_inode(trans, root, &path, &root_dir_key, 1);
|
ret = btrfs_lookup_inode(trans, root, &path, &root_dir_key, 1);
|
||||||
if (ret) {
|
if (ret) {
|
||||||
error("failed to lookup root dir: %d", ret);
|
error("failed to lookup root dir: %d", ret);
|
||||||
|
|
|
@ -57,7 +57,7 @@ int main(int ac, char **av) {
|
||||||
}
|
}
|
||||||
trans = btrfs_start_transaction(root, 1);
|
trans = btrfs_start_transaction(root, 1);
|
||||||
srand(55);
|
srand(55);
|
||||||
btrfs_set_key_type(&ins, BTRFS_STRING_ITEM_KEY);
|
ins.type = BTRFS_STRING_ITEM_KEY;
|
||||||
for (i = 0; i < run_size; i++) {
|
for (i = 0; i < run_size; i++) {
|
||||||
num = next_key(i, max_key);
|
num = next_key(i, max_key);
|
||||||
// num = i;
|
// num = i;
|
||||||
|
|
|
@ -37,7 +37,7 @@ static int setup_key(struct radix_tree_root *root, struct btrfs_key *key,
|
||||||
int ret;
|
int ret;
|
||||||
|
|
||||||
key->flags = 0;
|
key->flags = 0;
|
||||||
btrfs_set_key_type(key, BTRFS_STRING_ITEM_KEY);
|
key->type = BTRFS_STRING_ITEM_KEY;
|
||||||
key->offset = 0;
|
key->offset = 0;
|
||||||
again:
|
again:
|
||||||
ret = radix_tree_gang_lookup(root, (void **)res, num, 2);
|
ret = radix_tree_gang_lookup(root, (void **)res, num, 2);
|
||||||
|
@ -184,7 +184,7 @@ static int empty_tree(struct btrfs_trans_handle *trans, struct btrfs_root
|
||||||
|
|
||||||
key.offset = 0;
|
key.offset = 0;
|
||||||
key.flags = 0;
|
key.flags = 0;
|
||||||
btrfs_set_key_type(&key, BTRFS_STRING_ITEM_KEY);
|
key.type = BTRFS_STRING_ITEM_KEY;
|
||||||
key.objectid = (unsigned long)-1;
|
key.objectid = (unsigned long)-1;
|
||||||
while(nr-- >= 0) {
|
while(nr-- >= 0) {
|
||||||
btrfs_init_path(&path);
|
btrfs_init_path(&path);
|
||||||
|
@ -288,7 +288,7 @@ static int fill_radix(struct btrfs_root *root, struct radix_tree_root *radix)
|
||||||
|
|
||||||
key.offset = 0;
|
key.offset = 0;
|
||||||
key.flags = 0;
|
key.flags = 0;
|
||||||
btrfs_set_key_type(&key, BTRFS_STRING_ITEM_KEY);
|
key.type = BTRFS_STRING_ITEM_KEY;
|
||||||
key.objectid = (unsigned long)-1;
|
key.objectid = (unsigned long)-1;
|
||||||
while(1) {
|
while(1) {
|
||||||
btrfs_init_path(&path);
|
btrfs_init_path(&path);
|
||||||
|
|
Loading…
Reference in New Issue