From f11a740266cf5504693c8cd32e000d1a3ab77098 Mon Sep 17 00:00:00 2001 From: Piotr Caban Date: Thu, 31 Oct 2019 11:22:07 +0100 Subject: [PATCH] regedit: Fix double free error in GetValueName. Signed-off-by: Piotr Caban Signed-off-by: Alexandre Julliard --- programs/regedit/listview.c | 9 +-------- 1 file changed, 1 insertion(+), 8 deletions(-) diff --git a/programs/regedit/listview.c b/programs/regedit/listview.c index cdcaa8e067b..0132cfb8db8 100644 --- a/programs/regedit/listview.c +++ b/programs/regedit/listview.c @@ -38,7 +38,6 @@ DWORD g_columnToSort = ~0U; BOOL g_invertSort = FALSE; WCHAR *g_currentPath; HKEY g_currentRootKey; -static WCHAR *g_valueName; static WCHAR g_szValueNotSet[64]; #define MAX_LIST_COLUMNS (IDS_LIST_COLUMN_LAST - IDS_LIST_COLUMN_FIRST + 1) @@ -66,16 +65,10 @@ WCHAR *GetValueName(HWND hwndLV) { INT item; - if (g_valueName != LPSTR_TEXTCALLBACKW) - heap_free(g_valueName); - g_valueName = NULL; - item = SendMessageW(hwndLV, LVM_GETNEXTITEM, -1, MAKELPARAM(LVNI_FOCUSED, 0)); if (item == -1) return NULL; - g_valueName = GetItemText(hwndLV, item); - - return g_valueName; + return GetItemText(hwndLV, item); } BOOL update_listview_path(const WCHAR *path)