marko10_000
/
wine-wine
forked from Mirrors/wine-wine
1
0
Fork 0
Code Issues Pull Requests Releases Wiki Activity

shell32: Return S_OK in ::SetPropertyBag.

oldstable
David Hedberg 2010-12-19 22:11:23 +01:00 committed by Alexandre Julliard
parent f6dad19730
commit dfc2f20b89
2 changed files with 16 additions and 1 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

10
dlls/shell32/ebrowser.c
View File

@ -931,7 +931,15 @@ static HRESULT WINAPI IExplorerBrowser_fnSetPropertyBag(IExplorerBrowser *iface,
ExplorerBrowserImpl *This = (ExplorerBrowserImpl*)iface;
FIXME("stub, %p (%s)\n", This, debugstr_w(pszPropertyBag));
return E_NOTIMPL;
if(!pszPropertyBag)
return E_INVALIDARG;
/* FIXME: This method is currently useless as we don't save any
* settings anywhere, but at least one application breaks if we
* return E_NOTIMPL.
*/
return S_OK;
}
static HRESULT WINAPI IExplorerBrowser_fnSetEmptyText(IExplorerBrowser *iface,

7
dlls/shell32/tests/ebrowser.c
View File

@ -1037,6 +1037,7 @@ static void test_basics(void)
HDWP hdwp;
RECT rc;
HRESULT hr;
static const WCHAR winetest[] = {'W','i','n','e','T','e','s','t',0};
ebrowser_instantiate(&peb);
ebrowser_initialize(peb);
@ -1145,6 +1146,12 @@ static void test_basics(void)
hr = IExplorerBrowser_SetFolderSettings(peb, &fs);
todo_wine ok(hr == E_INVALIDARG, "got (0x%08x)\n", hr);
/* SetPropertyBag */
hr = IExplorerBrowser_SetPropertyBag(peb, NULL);
ok(hr == E_INVALIDARG, "Got 0x%08x\n", hr);
hr = IExplorerBrowser_SetPropertyBag(peb, winetest);
ok(hr == S_OK, "Got 0x%08x\n", hr);
/* TODO: Test after browsing somewhere. */
IExplorerBrowser_Destroy(peb);