marko10_000
/
wine-wine
forked from Mirrors/wine-wine
1
0
Fork 0
Code Issues Pull Requests Releases Wiki Activity

winemenubuilder: Avoid warning about uninitialized value (clang).

oldstable
Lauri Kenttä 2011-05-17 23:33:03 +03:00 committed by Alexandre Julliard
parent 9f7c390ec8
commit c2705081ac
1 changed files with 3 additions and 5 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

8
programs/winemenubuilder/winemenubuilder.c
View File

@ -1012,8 +1012,7 @@ static HRESULT platform_write_icon(IStream *icoStream, int exeIndex, LPCWSTR ico
for (i = 0; i < numEntries; i++)
{
int bestIndex;
int maxBits = -1;
int bestIndex = i;
int j;
BOOLEAN duplicate = FALSE;
int w, h;
@ -1034,14 +1033,13 @@ static HRESULT platform_write_icon(IStream *icoStream, int exeIndex, LPCWSTR ico
}
if (duplicate)
continue;
for (j = i; j < numEntries; j++)
for (j = i + 1; j < numEntries; j++)
{
if (iconDirEntries[j].bWidth == iconDirEntries[i].bWidth &&
iconDirEntries[j].bHeight == iconDirEntries[i].bHeight &&
iconDirEntries[j].wBitCount >= maxBits)
iconDirEntries[j].wBitCount >= iconDirEntries[bestIndex].wBitCount)
{
bestIndex = j;
maxBits = iconDirEntries[j].wBitCount;
}
}
WINE_TRACE("Selected: %d\n", bestIndex);