From beeadfb055c17887b16bc38295f3fe735dd16193 Mon Sep 17 00:00:00 2001 From: Piotr Caban Date: Mon, 27 May 2019 17:36:17 +0200 Subject: [PATCH] services: Don't double release process in service_start. Fixes a crash while running ntoskrnl tests. Signed-off-by: Piotr Caban Signed-off-by: Alexandre Julliard (cherry picked from commit 496380709dfdeccd2ff12358e5bdb5b7b8338ac2) Signed-off-by: Michael Stefaniuc --- programs/services/services.c | 11 +++++++---- 1 file changed, 7 insertions(+), 4 deletions(-) diff --git a/programs/services/services.c b/programs/services/services.c index 3de46bd2003..8bb45677981 100644 --- a/programs/services/services.c +++ b/programs/services/services.c @@ -1066,10 +1066,13 @@ DWORD service_start(struct service_entry *service, DWORD service_argc, LPCWSTR * if (err != ERROR_SUCCESS) { service_lock(service); - service->status.dwCurrentState = SERVICE_STOPPED; - service->process = NULL; - if (!--process->use_count) process_terminate(process); - release_process(process); + if (service->process) + { + service->status.dwCurrentState = SERVICE_STOPPED; + service->process = NULL; + if (!--process->use_count) process_terminate(process); + release_process(process); + } service_unlock(service); }