From 669b79b8f541de9ff299f63ba5a8c2baeee1cc06 Mon Sep 17 00:00:00 2001 From: Robert Reif Date: Wed, 19 Oct 2005 19:21:38 +0000 Subject: [PATCH] Change secondary buffer variable name to secondary. Fix AddRef and Release to use proper class. --- dlls/dsound/buffer.c | 24 ++++++++++++------------ dlls/dsound/dsound.c | 6 +++--- dlls/dsound/dsound_private.h | 2 +- 3 files changed, 16 insertions(+), 16 deletions(-) diff --git a/dlls/dsound/buffer.c b/dlls/dsound/buffer.c index b4646beab28..84348063695 100644 --- a/dlls/dsound/buffer.c +++ b/dlls/dsound/buffer.c @@ -898,11 +898,11 @@ static HRESULT WINAPI IDirectSoundBufferImpl_QueryInterface( if ( IsEqualGUID(riid, &IID_IUnknown) || IsEqualGUID(riid, &IID_IDirectSoundBuffer) || IsEqualGUID(riid, &IID_IDirectSoundBuffer8) ) { - if (!This->dsb) - SecondaryBufferImpl_Create(This, &(This->dsb)); - if (This->dsb) { - IDirectSoundBuffer8_AddRef((LPDIRECTSOUNDBUFFER8)This->dsb); - *ppobj = This->dsb; + if (!This->secondary) + SecondaryBufferImpl_Create(This, &(This->secondary)); + if (This->secondary) { + IDirectSoundBuffer8_AddRef((LPDIRECTSOUNDBUFFER8)This->secondary); + *ppobj = This->secondary; return S_OK; } WARN("IID_IDirectSoundBuffer\n"); @@ -1012,7 +1012,7 @@ HRESULT WINAPI IDirectSoundBufferImpl_Create( TRACE("Created buffer at %p\n", dsb); dsb->ref = 0; - dsb->dsb = 0; + dsb->secondary = 0; dsb->dsound = ds; dsb->lpVtbl = &dsbvt; dsb->iks = NULL; @@ -1200,10 +1200,10 @@ HRESULT WINAPI IDirectSoundBufferImpl_Destroy( pdsb->notify = NULL; } - if (pdsb->dsb) { + if (pdsb->secondary) { WARN("dsb not NULL\n"); - SecondaryBufferImpl_Destroy(pdsb->dsb); - pdsb->dsb = NULL; + SecondaryBufferImpl_Destroy(pdsb->secondary); + pdsb->secondary = NULL; } while (IDirectSoundBuffer8_Release((LPDIRECTSOUNDBUFFER8)pdsb) > 0); @@ -1226,7 +1226,7 @@ static HRESULT WINAPI SecondaryBufferImpl_QueryInterface( static ULONG WINAPI SecondaryBufferImpl_AddRef(LPDIRECTSOUNDBUFFER8 iface) { - IDirectSoundBufferImpl *This = (IDirectSoundBufferImpl *)iface; + SecondaryBufferImpl *This = (SecondaryBufferImpl *)iface; ULONG ref = InterlockedIncrement(&(This->ref)); TRACE("(%p) ref was %ld\n", This, ref - 1); return ref; @@ -1234,12 +1234,12 @@ static ULONG WINAPI SecondaryBufferImpl_AddRef(LPDIRECTSOUNDBUFFER8 iface) static ULONG WINAPI SecondaryBufferImpl_Release(LPDIRECTSOUNDBUFFER8 iface) { - IDirectSoundBufferImpl *This = (IDirectSoundBufferImpl *)iface; + SecondaryBufferImpl *This = (SecondaryBufferImpl *)iface; ULONG ref = InterlockedDecrement(&(This->ref)); TRACE("(%p) ref was %ld\n", This, ref + 1); if (!ref) { - This->dsb->dsb = NULL; + This->dsb->secondary = NULL; IDirectSoundBuffer_Release((LPDIRECTSOUNDBUFFER8)This->dsb); HeapFree(GetProcessHeap(), 0, This); TRACE("(%p) released\n", This); diff --git a/dlls/dsound/dsound.c b/dlls/dsound/dsound.c index a654ede5c37..0163f8a5ccc 100644 --- a/dlls/dsound/dsound.c +++ b/dlls/dsound/dsound.c @@ -366,7 +366,7 @@ static HRESULT WINAPI DSOUND_CreateSoundBuffer( if (dsb) { hres = SecondaryBufferImpl_Create(dsb, (SecondaryBufferImpl**)ppdsb); if (*ppdsb) { - dsb->dsb = (SecondaryBufferImpl*)*ppdsb; + dsb->secondary = (SecondaryBufferImpl*)*ppdsb; IDirectSoundBuffer_AddRef((LPDIRECTSOUNDBUFFER)*ppdsb); } else WARN("SecondaryBufferImpl_Create failed\n"); @@ -535,7 +535,7 @@ static HRESULT WINAPI IDirectSoundImpl_DuplicateSoundBuffer( dsb->dsound = This; dsb->ds3db = NULL; dsb->iks = NULL; /* FIXME? */ - dsb->dsb = NULL; + dsb->secondary = NULL; /* variable sized struct so calculate size based on format */ size = sizeof(WAVEFORMATEX) + pdsb->pwfx->cbSize; @@ -567,7 +567,7 @@ static HRESULT WINAPI IDirectSoundImpl_DuplicateSoundBuffer( } else { hres = SecondaryBufferImpl_Create(dsb, (SecondaryBufferImpl**)ppdsb); if (*ppdsb) { - dsb->dsb = (SecondaryBufferImpl*)*ppdsb; + dsb->secondary = (SecondaryBufferImpl*)*ppdsb; IDirectSoundBuffer_AddRef((LPDIRECTSOUNDBUFFER8)*ppdsb); } else WARN("SecondaryBufferImpl_Create failed\n"); diff --git a/dlls/dsound/dsound_private.h b/dlls/dsound/dsound_private.h index 08f2628b241..944335dd174 100644 --- a/dlls/dsound/dsound_private.h +++ b/dlls/dsound/dsound_private.h @@ -199,7 +199,7 @@ struct IDirectSoundBufferImpl const IDirectSoundBuffer8Vtbl *lpVtbl; LONG ref; /* IDirectSoundBufferImpl fields */ - SecondaryBufferImpl* dsb; + SecondaryBufferImpl* secondary; IDirectSoundImpl* dsound; CRITICAL_SECTION lock; PIDSDRIVERBUFFER hwbuf;