marko10_000
/
wine-wine
forked from Mirrors/wine-wine
1
0
Fork 0
Code Issues Pull Requests Releases Wiki Activity

msi: Fix memory leaks (found by Smatch).

oldstable
Rico Schüller 2007-12-31 01:04:56 +01:00 committed by Alexandre Julliard
parent 066ccd1275
commit 63c5e152a1
2 changed files with 10 additions and 0 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

3
dlls/msi/dialog.c
View File

@ -2268,7 +2268,10 @@ static UINT msi_dialog_list_box( msi_dialog *dialog, MSIRECORD *rec )
control = msi_dialog_add_control( dialog, rec, WC_LISTBOXW, style );
if (!control)
{
msi_free(info);
return ERROR_FUNCTION_FAILED;
}
control->handler = msi_dialog_listbox_handler;

7
dlls/msi/source.c
View File

@ -605,7 +605,10 @@ static UINT fill_source_list(struct list *sourcelist, HKEY sourcekey, DWORD *cou
entry->path = msi_alloc(val_size);
if (!entry->path)
{
msi_free(entry);
goto error;
}
lstrcpyW(entry->szIndex, name);
entry->index = atoiW(name);
@ -614,7 +617,11 @@ static UINT fill_source_list(struct list *sourcelist, HKEY sourcekey, DWORD *cou
r = RegEnumValueW(sourcekey, index, name, &size, NULL,
NULL, (LPBYTE)entry->path, &val_size);
if (r != ERROR_SUCCESS)
{
msi_free(entry->path);
msi_free(entry);
goto error;
}
index = ++(*count);
add_source_to_list(sourcelist, entry);