marko10_000
/
wine-wine
forked from Mirrors/wine-wine
1
0
Fork 0
Code Issues Pull Requests Releases Wiki Activity

menubuilder: Use va_start/va_end around vsnprintf() on every call.

oldstable
Nikolay Sivov 2012-02-16 03:28:29 +03:00 committed by Alexandre Julliard
parent 98f0be8dc3
commit 4db6d184b3
1 changed files with 3 additions and 2 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

5
programs/winemenubuilder/winemenubuilder.c
View File

@ -236,13 +236,14 @@ static char* heap_printf(const char *format, ...)
char *buffer, *ret;
int n;
va_start(args, format);
while (1)
{
buffer = HeapAlloc(GetProcessHeap(), 0, size);
if (buffer == NULL)
break;
va_start(args, format);
n = vsnprintf(buffer, size, format, args);
va_end(args);
if (n == -1)
size *= 2;
else if (n >= size)
@ -251,7 +252,7 @@ static char* heap_printf(const char *format, ...)
break;
HeapFree(GetProcessHeap(), 0, buffer);
}
va_end(args);
if (!buffer) return NULL;
ret = HeapReAlloc(GetProcessHeap(), 0, buffer, strlen(buffer) + 1 );
if (!ret) ret = buffer;