From 477e7fdfc0f7ccff9fbe9c3c69a37899e006f51d Mon Sep 17 00:00:00 2001 From: Nikolay Sivov Date: Thu, 10 Nov 2016 14:47:10 +0300 Subject: [PATCH] ieframe: Fix moniker leak on error path. Signed-off-by: Nikolay Sivov Signed-off-by: Jacek Caban Signed-off-by: Alexandre Julliard --- dlls/ieframe/navigate.c | 5 ++++- 1 file changed, 4 insertions(+), 1 deletion(-) diff --git a/dlls/ieframe/navigate.c b/dlls/ieframe/navigate.c index 296ed19a387..658857faddc 100644 --- a/dlls/ieframe/navigate.c +++ b/dlls/ieframe/navigate.c @@ -703,13 +703,16 @@ static HRESULT bind_to_object(DocHost *This, IMoniker *mon, LPCWSTR url, IBindCt hres = IMoniker_GetDisplayName(mon, 0, NULL, &display_name); if(FAILED(hres)) { FIXME("GetDisplayName failed: %08x\n", hres); + IMoniker_Release(mon); return hres; } hres = set_dochost_url(This, display_name); CoTaskMemFree(display_name); - if(FAILED(hres)) + if(FAILED(hres)) { + IMoniker_Release(mon); return hres; + } IBindCtx_RegisterObjectParam(bindctx, (LPOLESTR)SZ_HTML_CLIENTSITE_OBJECTPARAM, (IUnknown*)&This->IOleClientSite_iface);