From 1fed032a43a23df80de7da6f7dbf23b4ed2a020f Mon Sep 17 00:00:00 2001 From: James Hawkins Date: Tue, 8 Jul 2008 23:56:26 -0500 Subject: [PATCH] msi: Only copy the resulting string if the RegistryValue call succeeded. --- dlls/msi/tests/automation.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/dlls/msi/tests/automation.c b/dlls/msi/tests/automation.c index 03154e1d322..2c741e8a99e 100644 --- a/dlls/msi/tests/automation.c +++ b/dlls/msi/tests/automation.c @@ -804,7 +804,7 @@ static HRESULT Installer_RegistryValueI(HKEY hkey, LPCWSTR szKey, int iValue, LP V_I4(&vararg) = iValue; hr = Installer_RegistryValue(hkey, szKey, vararg, &varresult, vtResult); - if (vtResult == VT_BSTR) lstrcpyW(szString, V_BSTR(&varresult)); + if (SUCCEEDED(hr) && vtResult == VT_BSTR) lstrcpyW(szString, V_BSTR(&varresult)); VariantClear(&varresult); return hr; }