marko10_000
/
wine-wine
forked from Mirrors/wine-wine
1
0
Fork 0
Code Issues Pull Requests Releases Wiki Activity

dxdiagn: Improve error handling when converting to VT_BSTR (Coverity). 

Signed-off-by: Nikolay Sivov <nsivov@codeweavers.com>
Signed-off-by: Alexandre Julliard <julliard@winehq.org>
oldstable
Nikolay Sivov 2015-12-22 00:51:36 +03:00 committed by Alexandre Julliard
parent a0b8f178df
commit 0aa56cabe4
1 changed files with 7 additions and 1 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

8
dlls/dxdiagn/provider.c
View File

@ -346,6 +346,7 @@ static inline HRESULT add_bool_property(IDxDiagContainerImpl_Container *node, co
static inline HRESULT add_ull_as_bstr_property(IDxDiagContainerImpl_Container *node, const WCHAR *propName, ULONGLONG data )
{
IDxDiagContainerImpl_Property *prop;
HRESULT hr;
prop = allocate_property_information(propName);
if (!prop)
@ -354,7 +355,12 @@ static inline HRESULT add_ull_as_bstr_property(IDxDiagContainerImpl_Container *n
V_VT(&prop->vProp) = VT_UI8;
V_UI8(&prop->vProp) = data;
VariantChangeType(&prop->vProp, &prop->vProp, 0, VT_BSTR);
hr = VariantChangeType(&prop->vProp, &prop->vProp, 0, VT_BSTR);
if (FAILED(hr))
{
free_property_information(prop);
return hr;
}
list_add_tail(&node->properties, &prop->entry);
++node->nProperties;