From 28207160573ee7c577a690e0de91270826eed6de Mon Sep 17 00:00:00 2001
From: =?UTF-8?q?G=C3=BCnther=20Brammer?= <gbrammer@gmx.de>
Date: Fri, 11 Mar 2011 03:43:38 +0100
Subject: [PATCH] Include fewer headers from C4Game.h so C4NetIO.h isn't
 included from there

---
 src/C4Game.cpp                      |  7 +++++++
 src/C4Game.h                        | 19 ++++++++-----------
 src/C4Prototypes.h                  |  8 ++++++++
 src/control/C4Control.cpp           |  1 +
 src/control/C4GameSave.cpp          |  1 +
 src/game/landscape/C4MassMover.cpp  |  1 +
 src/game/landscape/C4PXS.cpp        |  1 +
 src/game/object/C4Def.cpp           |  1 +
 src/game/object/C4DefList.cpp       |  1 +
 src/game/object/C4DefList.h         |  3 +++
 src/game/object/C4ObjectMenu.cpp    |  1 +
 src/game/object/C4ObjectScript.cpp  |  1 +
 src/game/player/C4PlayerList.cpp    |  1 +
 src/game/script/C4GameScript.cpp    |  1 +
 src/gui/C4KeyboardInput.cpp         |  1 +
 src/gui/C4MouseControl.h            |  1 +
 src/gui/C4PlayerInfoListBox.cpp     |  1 +
 src/network/C4Network2Players.cpp   |  1 +
 src/network/C4Network2Reference.cpp |  6 ++++--
 src/platform/StdFont.cpp            |  1 +
 src/platform/StdTApp.cpp            |  1 +
 21 files changed, 46 insertions(+), 13 deletions(-)

diff --git a/src/C4Game.cpp b/src/C4Game.cpp
index 99ea7ed4a..8da881aa8 100644
--- a/src/C4Game.cpp
+++ b/src/C4Game.cpp
@@ -55,6 +55,7 @@
 #include <C4Log.h>
 #include <C4Player.h>
 #include <C4GameOverDlg.h>
+#include <C4GameParameters.h>
 #include <C4ObjectMenu.h>
 #include <C4GameLobby.h>
 #include <C4ChatDlg.h>
@@ -64,6 +65,7 @@
 #include <C4MessageInput.h>
 #include <C4MassMover.h>
 #include <C4RankSystem.h>
+#include <C4RoundResults.h>
 #include <C4GameMessage.h>
 #include <C4Material.h>
 #include <C4Network2Reference.h>
@@ -88,11 +90,16 @@ public:
 	void OnSec1Timer();
 };
 
+static C4GameParameters GameParameters;
+static C4RoundResults GameRoundResults;
+
 C4Game::C4Game()
 		: Clients(Parameters.Clients),
+		Parameters(GameParameters),
 		Teams(Parameters.Teams),
 		PlayerInfos(Parameters.PlayerInfos),
 		RestorePlayerInfos(Parameters.RestorePlayerInfos),
+		RoundResults(GameRoundResults),
 		Input(Control.Input),
 		KeyboardInput(C4KeyboardInput_Init()),
 		pFileMonitor(NULL),
diff --git a/src/C4Game.h b/src/C4Game.h
index c580b1b22..bffaf1295 100644
--- a/src/C4Game.h
+++ b/src/C4Game.h
@@ -24,10 +24,7 @@
 #ifndef INC_C4Game
 #define INC_C4Game
 
-#include <C4GameParameters.h>
-#include <C4RoundResults.h>
 #include <C4Scenario.h>
-#include <C4Control.h>
 #include <C4PathFinder.h>
 #include <C4Extra.h>
 #include "C4Scoreboard.h"
@@ -61,11 +58,11 @@ public:
 	~C4Game();
 
 	C4ClientList       &Clients; // Shortcut
-	C4GameParameters    Parameters;
+	C4GameParameters    &Parameters;
 	C4TeamList         &Teams; // Shortcut
 	C4PlayerInfoList   &PlayerInfos; // Shortcut
 	C4PlayerInfoList   &RestorePlayerInfos; // Shortcut
-	C4RoundResults      RoundResults;
+	C4RoundResults      &RoundResults;
 	C4Scenario          C4S;
 	C4ComponentHost     Info;
 	C4ComponentHost     Title;
@@ -87,10 +84,10 @@ public:
 	C4PlayerControlAssignmentSets PlayerControlAssignmentSets;
 	C4Scoreboard        Scoreboard;
 	C4VideoPlayer       VideoPlayer;
-	class C4Network2Stats *pNetworkStatistics; // may be NULL if no statistics are recorded
-	class C4KeyboardInput &KeyboardInput;
-	class C4FileMonitor *pFileMonitor;
-	class C4GameSec1Timer *pSec1Timer;
+	C4Network2Stats *pNetworkStatistics; // may be NULL if no statistics are recorded
+	C4KeyboardInput &KeyboardInput;
+	C4FileMonitor *pFileMonitor;
+	C4GameSec1Timer *pSec1Timer;
 
 	char CurrentScenarioSection[C4MaxName+1];
 	char ScenarioFilename[_MAX_PATH+1];
@@ -98,7 +95,7 @@ public:
 	char PlayerFilenames[20*_MAX_PATH+1];
 	char DefinitionFilenames[20*_MAX_PATH+1];
 	char DirectJoinAddress[_MAX_PATH+1];
-	class C4Network2Reference *pJoinReference;
+	C4Network2Reference *pJoinReference;
 	int32_t StartupPlayerCount;
 	int32_t FPS,cFPS;
 	int32_t HaltCount;
@@ -154,7 +151,7 @@ public:
 	bool PreInit();
 	void SetScenarioFilename(const char*);
 	bool Execute();
-	class C4Player *JoinPlayer(const char *szFilename, int32_t iAtClient, const char *szAtClientName, C4PlayerInfo *pInfo);
+	C4Player *JoinPlayer(const char *szFilename, int32_t iAtClient, const char *szAtClientName, C4PlayerInfo *pInfo);
 	bool DoGameOver();
 	bool CanQuickSave();
 	bool QuickSave(const char *strFilename, const char *strTitle, bool fForceSave=false);
diff --git a/src/C4Prototypes.h b/src/C4Prototypes.h
index e5aa3ea38..2bf01e6d7 100644
--- a/src/C4Prototypes.h
+++ b/src/C4Prototypes.h
@@ -33,16 +33,19 @@ class C4AulScript;
 class C4AulScriptEngine;
 class C4AulScriptFunc;
 struct C4AulParSet;
+class C4ClientList;
 class C4ClientPlayerInfos;
 class C4Command;
 class C4Config;
 class C4Console;
+class C4Control;
 class C4Def;
 class C4DefList;
 class C4DefGraphics;
 class C4Effect;
 class C4Facet;
 class C4FacetSurface;
+class C4FileMonitor;
 class C4Game;
 class C4GameMessage;
 class C4GameMessageList;
@@ -50,13 +53,16 @@ class C4GameOptionsList;
 class C4GamePadControl;
 class C4GamePadOpener;
 class C4GamePadOpener;
+class C4GameParameters;
 class C4GameResList;
+class C4GameSec1Timer;
 class C4Graph;
 class C4GraphicsSystem;
 class C4Group;
 class C4Group;
 class C4GroupSet;
 class C4IDList;
+class C4KeyboardInput;
 class C4LChunk;
 class C4League;
 class C4LoaderScreen;
@@ -75,6 +81,8 @@ class C4Network;
 class C4NetworkClient;
 class C4NetworkClientList;
 class C4Network2IRCClient;
+class C4Network2Stats;
+class C4Network2Reference;
 class C4Object;
 class C4ObjectInfo;
 class C4ObjectInfoCore;
diff --git a/src/control/C4Control.cpp b/src/control/C4Control.cpp
index 10cff90be..d3a615f9b 100644
--- a/src/control/C4Control.cpp
+++ b/src/control/C4Control.cpp
@@ -39,6 +39,7 @@
 #include <C4GraphicsSystem.h>
 #include <C4Player.h>
 #include <C4RankSystem.h>
+#include <C4RoundResults.h>
 #include <C4PXS.h>
 #include <C4MassMover.h>
 #include <C4GameMessage.h>
diff --git a/src/control/C4GameSave.cpp b/src/control/C4GameSave.cpp
index 76631c49f..41eae2b80 100644
--- a/src/control/C4GameSave.cpp
+++ b/src/control/C4GameSave.cpp
@@ -36,6 +36,7 @@
 #include <C4ScriptHost.h>
 #include <C4PlayerList.h>
 #include <C4GameObjects.h>
+#include <C4RoundResults.h>
 #include <C4Record.h>
 #include <C4Version.h>
 
diff --git a/src/game/landscape/C4MassMover.cpp b/src/game/landscape/C4MassMover.cpp
index 8760dd921..812198062 100644
--- a/src/game/landscape/C4MassMover.cpp
+++ b/src/game/landscape/C4MassMover.cpp
@@ -24,6 +24,7 @@
 #include <C4Include.h>
 #include <C4MassMover.h>
 
+#include <C4Components.h>
 #include <C4Random.h>
 #include <C4Material.h>
 #include <C4Game.h>
diff --git a/src/game/landscape/C4PXS.cpp b/src/game/landscape/C4PXS.cpp
index 3c1bc1bf0..3e85f88f4 100644
--- a/src/game/landscape/C4PXS.cpp
+++ b/src/game/landscape/C4PXS.cpp
@@ -25,6 +25,7 @@
 #include <C4Include.h>
 #include <C4PXS.h>
 
+#include <C4Components.h>
 #include <C4Config.h>
 #include <C4Physics.h>
 #include <C4Random.h>
diff --git a/src/game/object/C4Def.cpp b/src/game/object/C4Def.cpp
index 8c66651f0..add4a9444 100644
--- a/src/game/object/C4Def.cpp
+++ b/src/game/object/C4Def.cpp
@@ -28,6 +28,7 @@
 #include <C4Include.h>
 #include <C4Def.h>
 
+#include <C4Components.h>
 #include <C4Config.h>
 #include <C4FileMonitor.h>
 #include <C4Language.h>
diff --git a/src/game/object/C4DefList.cpp b/src/game/object/C4DefList.cpp
index 48dd4a54b..61a149ac3 100644
--- a/src/game/object/C4DefList.cpp
+++ b/src/game/object/C4DefList.cpp
@@ -26,6 +26,7 @@
 #include <C4Include.h>
 #include <C4DefList.h>
 
+#include <C4Components.h>
 #include <C4Config.h>
 #include <C4Def.h>
 #include <C4FileMonitor.h>
diff --git a/src/game/object/C4DefList.h b/src/game/object/C4DefList.h
index a0dd6c719..ba865adee 100644
--- a/src/game/object/C4DefList.h
+++ b/src/game/object/C4DefList.h
@@ -23,6 +23,9 @@
 #ifndef INC_C4DefList
 #define INC_C4DefList
 
+#include <StdFont.h>
+#include <StdFacet.h>
+
 const int32_t C4D_None           =    0,
 C4D_All            =    ~C4D_None;
 
diff --git a/src/game/object/C4ObjectMenu.cpp b/src/game/object/C4ObjectMenu.cpp
index cf35bef13..db8c9a0d3 100644
--- a/src/game/object/C4ObjectMenu.cpp
+++ b/src/game/object/C4ObjectMenu.cpp
@@ -25,6 +25,7 @@
 #include "C4Include.h"
 #include "C4ObjectMenu.h"
 
+#include "C4Control.h"
 #include "C4Object.h"
 #include "C4ObjectCom.h"
 #include "C4Player.h"
diff --git a/src/game/object/C4ObjectScript.cpp b/src/game/object/C4ObjectScript.cpp
index e103fc173..49631d8ac 100644
--- a/src/game/object/C4ObjectScript.cpp
+++ b/src/game/object/C4ObjectScript.cpp
@@ -39,6 +39,7 @@
 #include <C4PlayerList.h>
 #include <C4Random.h>
 #include <C4RankSystem.h>
+#include <C4Teams.h>
 
 static bool FnChangeDef(C4AulObjectContext *cthr, C4ID to_id)
 {
diff --git a/src/game/player/C4PlayerList.cpp b/src/game/player/C4PlayerList.cpp
index 0fb6c5543..7a1197d8a 100644
--- a/src/game/player/C4PlayerList.cpp
+++ b/src/game/player/C4PlayerList.cpp
@@ -35,6 +35,7 @@
 #include <C4Viewport.h>
 #include <C4GameObjects.h>
 #include <C4GameControl.h>
+#include <C4RoundResults.h>
 
 C4PlayerList::C4PlayerList()
 {
diff --git a/src/game/script/C4GameScript.cpp b/src/game/script/C4GameScript.cpp
index c299d0919..d537ee7c1 100644
--- a/src/game/script/C4GameScript.cpp
+++ b/src/game/script/C4GameScript.cpp
@@ -46,6 +46,7 @@
 #include <C4Player.h>
 #include <C4PlayerList.h>
 #include <C4PXS.h>
+#include <C4RoundResults.h>
 #include <C4Texture.h>
 #include <C4Weather.h>
 #include <C4Viewport.h>
diff --git a/src/gui/C4KeyboardInput.cpp b/src/gui/C4KeyboardInput.cpp
index 88c2d28f7..5a2f05ac6 100644
--- a/src/gui/C4KeyboardInput.cpp
+++ b/src/gui/C4KeyboardInput.cpp
@@ -27,6 +27,7 @@
 #include <C4Include.h>
 #include <C4KeyboardInput.h>
 
+#include <C4Components.h>
 #include <C4Game.h>
 
 #ifdef USE_X11
diff --git a/src/gui/C4MouseControl.h b/src/gui/C4MouseControl.h
index 6cf45779d..74c565a8a 100644
--- a/src/gui/C4MouseControl.h
+++ b/src/gui/C4MouseControl.h
@@ -23,6 +23,7 @@
 #ifndef INC_C4MouseControl
 #define INC_C4MouseControl
 
+#include <C4Facet.h>
 #include "C4ObjectList.h"
 #include "C4Region.h"
 
diff --git a/src/gui/C4PlayerInfoListBox.cpp b/src/gui/C4PlayerInfoListBox.cpp
index e06050d59..11ca27ac2 100644
--- a/src/gui/C4PlayerInfoListBox.cpp
+++ b/src/gui/C4PlayerInfoListBox.cpp
@@ -39,6 +39,7 @@
 #include <C4MouseControl.h>
 #include <C4Network2.h>
 #include <C4GameControl.h>
+#include <C4RoundResults.h>
 
 DWORD GenerateRandomPlayerColor(int32_t iTry); // in C4PlayerInfoConflicts.cpp
 
diff --git a/src/network/C4Network2Players.cpp b/src/network/C4Network2Players.cpp
index cd2482793..82cfee32c 100644
--- a/src/network/C4Network2Players.cpp
+++ b/src/network/C4Network2Players.cpp
@@ -30,6 +30,7 @@
 #include <C4Game.h>
 #include <C4Network2.h>
 #include <C4GameControl.h>
+#include <C4RoundResults.h>
 
 #include "C4Control.h"
 
diff --git a/src/network/C4Network2Reference.cpp b/src/network/C4Network2Reference.cpp
index 6a6d36a44..a65f718de 100644
--- a/src/network/C4Network2Reference.cpp
+++ b/src/network/C4Network2Reference.cpp
@@ -21,10 +21,12 @@
  * See clonk_trademark_license.txt for full license.
  */
 #include "C4Include.h"
-#include <C4Game.h>
-#include "C4Version.h"
 #include "C4Network2Reference.h"
 
+#include <C4Game.h>
+#include <C4RoundResults.h>
+#include "C4Version.h"
+
 #include <utility>
 #include <fcntl.h>
 #include <zlib.h>
diff --git a/src/platform/StdFont.cpp b/src/platform/StdFont.cpp
index c708091c2..aed725ca5 100644
--- a/src/platform/StdFont.cpp
+++ b/src/platform/StdFont.cpp
@@ -24,6 +24,7 @@
 // text drawing facility for CStdDDraw
 
 #include "C4Include.h"
+#include <StdFont.h>
 #include <StdBuf.h>
 #include <StdDDraw2.h>
 #include <StdSurface2.h>
diff --git a/src/platform/StdTApp.cpp b/src/platform/StdTApp.cpp
index ac58e504a..c9f57b22e 100644
--- a/src/platform/StdTApp.cpp
+++ b/src/platform/StdTApp.cpp
@@ -25,6 +25,7 @@
 #include <C4Include.h>
 #ifdef USE_CONSOLE
 #include <StdWindow.h>
+#include <StdDDraw2.h>
 #include <C4Application.h>
 
 #ifdef HAVE_LIBREADLINE