marko10_000
/
flatpak-builder
forked from Mirrors/flatpak-builder
1
0
Fork 0
Code Issues Pull Requests Releases Wiki Activity

Fix crashes on git errors 

We returned FALSE but error was unset, leading to a crash printing
the error message.

Closes: #62
Approved by: alexlarsson
tingping/wmclass
Alexander Larsson 2017-11-06 10:31:27 +01:00 committed by Atomic Bot
parent 202dcf7e9d
commit c5cd6f50f6
1 changed files with 2 additions and 2 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

4
src/builder-git.c
View File

@ -618,7 +618,7 @@ builder_git_shallow_mirror_ref (const char *repo_location,
return FALSE;
}
if (!git (cache_mirror_dir, &full_ref, 0, NULL,
if (!git (cache_mirror_dir, &full_ref, 0, error,
"rev-parse", "--symbolic-full-name", ref, NULL))
return FALSE;
@ -630,7 +630,7 @@ builder_git_shallow_mirror_ref (const char *repo_location,
g_free (full_ref);
/* We can't pull the commit id, so we create a ref we can pull */
full_ref = g_strdup_printf ("refs/heads/flatpak-builder-internal/commit/%s", ref);
if (!git (cache_mirror_dir, NULL, 0, NULL,
if (!git (cache_mirror_dir, NULL, 0, error,
"update-ref", full_ref, ref, NULL))
return FALSE;
}