marko10_000
/
flatpak-builder
forked from Mirrors/flatpak-builder
1
0
Fork 0
Code Issues Pull Requests Releases Wiki Activity

builder-source: Check for type == NULL before dereferencing

tingping/wmclass
Alexander Larsson 2016-11-11 10:48:37 +01:00
parent 9a2e68406c
commit 7c0ef5dccb
1 changed files with 3 additions and 3 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

6
builder/builder-source.c
View File

@ -209,7 +209,9 @@ builder_source_from_json (JsonNode *node)
type = json_object_get_string_member (object, "type");
if (strcmp (type, "archive") == 0)
if (type == NULL)
g_warning ("Missing source type");
else if (strcmp (type, "archive") == 0)
return (BuilderSource *) json_gobject_deserialize (BUILDER_TYPE_SOURCE_ARCHIVE, node);
if (strcmp (type, "file") == 0)
return (BuilderSource *) json_gobject_deserialize (BUILDER_TYPE_SOURCE_FILE, node);
@ -223,8 +225,6 @@ builder_source_from_json (JsonNode *node)
return (BuilderSource *) json_gobject_deserialize (BUILDER_TYPE_SOURCE_GIT, node);
if (strcmp (type, "bzr") == 0)
return (BuilderSource *) json_gobject_deserialize (BUILDER_TYPE_SOURCE_BZR, node);
else if (type == NULL)
g_warning ("Missing source type");
else
g_warning ("Unknown source type %s", type);