marko10_000
/
flatpak-builder
forked from Mirrors/flatpak-builder
1
0
Fork 0
Code Issues Pull Requests Releases Wiki Activity

exec* returns -1 on error 

...so use the == -1 idiom as already used in common/flatpak-run.c
(another fix would be to drop the if completely, as exec* doesn't
return on success)
tingping/wmclass
Stephan Bergmann 2016-05-24 17:44:33 +02:00
parent cb41e1bdba
commit 3b6b0da108
2 changed files with 2 additions and 2 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

2
app/flatpak-builtins-build.c
View File

@ -222,7 +222,7 @@ flatpak_builtin_build (int argc, char **argv, GCancellable *cancellable, GError
g_ptr_array_add (argv_array, NULL);
if (!execve (flatpak_get_bwrap (), (char **) argv_array->pdata, envp))
if (execve (flatpak_get_bwrap (), (char **) argv_array->pdata, envp) == -1)
{
g_set_error (error, G_IO_ERROR, g_io_error_from_errno (errno), "Unable to start app");
return FALSE;

2
builder/builder-manifest.c
View File

@ -2052,7 +2052,7 @@ builder_manifest_run (BuilderManifest *self,
commandline = g_strjoinv (" ", (char **) args->pdata);
if (!execvp ((char *) args->pdata[0], (char **) args->pdata))
if (execvp ((char *) args->pdata[0], (char **) args->pdata) == -1)
{
g_set_error (error, G_IO_ERROR, g_io_error_from_errno (errno), "Unable to start flatpak build");
return FALSE;