forked from Mirrors/btrfs-progs
bb1b07848e
When a scrub completes or is cancelled, statistics are updated for reporting in a later btrfs scrub status command and for resuming the scrub. Most statistics (such as bytes scrubbed) are additive so scrub adds the statistics from the current run to the saved statistics. However, the last_physical statistic is not additive. The value from the current run should replace the saved value. The current code incorrectly adds the last_physical from the current run to the previous saved value. This bug causes the resume point to be incorrectly recorded, so large areas of the disk are skipped when the scrub resumes. As an example, assume a disk had 1000000 bytes and scrub was cancelled and resumed each time 10% (100000 bytes) had been scrubbed. Run | Start byte | bytes scrubbed | kernel last_physical | saved last_physical 1 | 0 | 100000 | 100000 | 100000 2 | 100000 | 100000 | 200000 | 300000 3 | 300000 | 100000 | 400000 | 700000 4 | 700000 | 100000 | 800000 | 1500000 5 | 1500000 | 0 | immediately completes| completed In this example, only 40% of the disk is actually scrubbed. This patch changes the saved/displayed last_physical to track the last reported value from the kernel. Signed-off-by: Graham R. Cobb <g.btrfs@cobb.uk.net> Signed-off-by: David Sterba <dsterba@suse.com> |
||
|---|---|---|
| .. | ||
| balance.c | ||
| commands.h | ||
| device.c | ||
| filesystem-du.c | ||
| filesystem-usage.c | ||
| filesystem-usage.h | ||
| filesystem.c | ||
| inspect-dump-super.c | ||
| inspect-dump-tree.c | ||
| inspect-tree-stats.c | ||
| inspect.c | ||
| property.c | ||
| qgroup.c | ||
| quota.c | ||
| receive.c | ||
| replace.c | ||
| rescue-chunk-recover.c | ||
| rescue-super-recover.c | ||
| rescue.c | ||
| rescue.h | ||
| restore.c | ||
| scrub.c | ||
| send.c | ||
| subvolume.c | ||