b20f94e984
As seem in issue #192, this test can fail from time to time. The issue happens when a mount is issued before the new device is processed by systemd-udevd, as we can see by the og bellow: [ 2346.028809] BTRFS: device fsid 593e23af-a7e6-4360-b16a-229f415de697 devid 1 transid 6 /dev/loop10 scanned by systemd-udevd (3418) [ 2346.265401] BTRFS info (device loop10): found metadata UUID change in progress flag, clearing [ 2346.272474] BTRFS info (device loop10): disk space caching is enabled [ 2346.277472] BTRFS info (device loop10): has skinny extents [ 2346.281840] BTRFS info (device loop10): flagging fs with big metadata feature [ 2346.308428] BTRFS error (device loop10): devid 2 uuid cde07de6-db7e-4b34-909e-d3db6e7c0b06 is missing [ 2346.315363] BTRFS error (device loop10): failed to read the system array: -2 [ 2346.329887] BTRFS error (device loop10): open_ctree failed failed: mount /dev/loop10 /home/marcos/git/suse/btrfs-progs/tests//mnt test failed for case 034-metadata-uuid make: *** [Makefile:401: test-misc] Error 1 [ 2346.666865] BTRFS: device fsid 593e23af-a7e6-4360-b16a-229f415de697 devid 2 transid 5 /dev/loop11 scanned by systemd-udevd (3422) [ 2346.853233] BTRFS: device fsid 1c2debeb-e829-4d6b-84df-aa7c5d246fd5 devid 1 transid 7 /dev/loop6 scanned by systemd-udevd (3418) A few moments after the test failed systemd-udevd processed the new device (registered the new device under btrfs). This can be tested by executing a mount after the test failed, resulting in a successful mount: $ mount /dev/loop10 /mnt [ 2398.955254] BTRFS info (device loop10): found metadata UUID change in progress flag, clearing [ 2398.959416] BTRFS info (device loop10): disk space caching is enabled [ 2398.962483] BTRFS info (device loop10): has skinny extents [ 2398.965070] BTRFS info (device loop10): flagging fs with big metadata feature [ 2399.012617] BTRFS info (device loop10): enabling ssd optimizations [ 2399.022375] BTRFS info (device loop10): checking UUID tree This problem can be avoided is we execute "udevadm settle" before the mount is executed. Issue: #192 Reviewed-by: Nikolay Borisov <nborisov@suse.com> Reviewed-by: Su Yue <Damenly_Su@gmx.com> Signed-off-by: Marcos Paulo de Souza <mpdesouza@suse.com> Signed-off-by: David Sterba <dsterba@suse.com> |
||
---|---|---|
Documentation | ||
check | ||
ci | ||
cmds | ||
common | ||
convert | ||
crypto | ||
image | ||
kernel-lib | ||
kernel-shared | ||
libbtrfsutil | ||
m4 | ||
mkfs | ||
tests | ||
.gitignore | ||
.gitlab-ci.yml | ||
.travis.yml | ||
64-btrfs-dm.rules | ||
Android.mk | ||
CHANGES | ||
COPYING | ||
INSTALL | ||
Makefile | ||
Makefile.extrawarn | ||
Makefile.inc.in | ||
README.md | ||
VERSION | ||
androidcompat.h | ||
autogen.sh | ||
backref.c | ||
backref.h | ||
bcp | ||
btrfs-completion | ||
btrfs-corrupt-block.c | ||
btrfs-crc.c | ||
btrfs-debugfs | ||
btrfs-find-root.c | ||
btrfs-fragments.c | ||
btrfs-list.c | ||
btrfs-list.h | ||
btrfs-map-logical.c | ||
btrfs-sb-mod.c | ||
btrfs-select-super.c | ||
btrfs.c | ||
btrfsck.h | ||
btrfstune.c | ||
common-defs.h | ||
configure.ac | ||
ctree.c | ||
ctree.h | ||
delayed-ref.c | ||
delayed-ref.h | ||
dir-item.c | ||
disk-io.c | ||
disk-io.h | ||
extent-cache.c | ||
extent-cache.h | ||
extent-tree.c | ||
extent_io.c | ||
extent_io.h | ||
file-item.c | ||
file.c | ||
find-root.c | ||
find-root.h | ||
free-space-cache.c | ||
free-space-cache.h | ||
free-space-tree.c | ||
free-space-tree.h | ||
fsck.btrfs | ||
hash.h | ||
hasher.c | ||
inode-item.c | ||
inode-map.c | ||
inode.c | ||
ioctl-test.c | ||
ioctl.h | ||
kerncompat.h | ||
libbtrfs.sym | ||
library-test.c | ||
print-tree.c | ||
print-tree.h | ||
props.c | ||
props.h | ||
qgroup.c | ||
qgroup.h | ||
quick-test.c | ||
random-test.c | ||
repair.c | ||
repair.h | ||
root-tree.c | ||
send-dump.c | ||
send-dump.h | ||
send-stream.c | ||
send-stream.h | ||
send-utils.c | ||
send-utils.h | ||
send.h | ||
show-blocks | ||
transaction.c | ||
transaction.h | ||
utils-lib.c | ||
uuid-tree.c | ||
version.h.in | ||
volumes.c | ||
volumes.h |
README.md
Btrfs-progs
Userspace utilities to manage btrfs filesystems. License: GPLv2.
Btrfs is a copy on write (COW) filesystem for Linux aimed at implementing advanced features while focusing on fault tolerance, repair and easy administration.
This repository hosts following utilities:
- btrfs — the main administration tool (manual page)
- mkfs.btrfs — utility to create the filesystem (manual page)
- all-in-one binary in the busybox style with mkfs.btrfs, btrfs-image and other tools built-in (standalone tools)
The C and python 3 bindings are provided by a LGPL library libbtrfsutil see libbtrfsutil/README.md for more.
See INSTALL for build instructions and tests/README.md for testing information.
Release cycle
The major version releases are time-based and follow the cycle of the linux kernel releases. The cycle usually takes 2 months. A minor version releases may happen in the meantime if there are bug fixes or minor useful improvements queued.
The release tags are signed with a GPG key ID F2B4 1200 C54E FB30 380C 1756 C565 D5F9 D76D 583B
,
release tarballs are hosted at kernel.org.
See file CHANGES or changelogs on wiki.
Reporting bugs
There are several ways, each has its own specifics and audience that can give feedback or work on a fix. The following list is sorted in the order of preference:
- github issue tracker
- to the mailing list linux-btrfs@vger.kernel.org -- (not required to subscribe), beware that the mail might get overlooked in other traffic
- IRC (irc.freenode.net #btrfs) -- good for discussions eg. if a bug is already known, but reports could miss developers' attention
- bugzilla.kernel.org -- (requires registration), set the product to Filesystems and component Btrfs, please put 'btrfs-progs' into the subject so it's clear that it's not a kernel bug report
Development
The patch submissions, development or general discussions take place at linux-btrfs@vger.kernel.org mailinglist, subsciption is not required to post.
The GitHub pull requests will not be accepted directly, the preferred way is to send patches to the mailinglist instead. You can link to a branch in any git repository if the mails do not make it to the mailinglist or just for convenience (makes it easier to test).
The development model of btrfs-progs shares a lot with the kernel model. The github way is different in some ways. We, the upstream community, expect that the patches meet some criteria (often lacking in github contributions):
- one logical change per patch: eg. not mixing bugfixes, cleanups, features etc., sometimes it's not clear and will be usually pointed out during reviews
- proper subject line: eg. prefix with btrfs-progs: subpart, ... ,
descriptive yet not too long, see
git log --oneline
for some inspiration - proper changelog: the changelogs are often missing or lacking explanation why the change was made, or how is something broken, what are user-visible effects of the bug or the fix, how does an improvement help or the intended usecase
- the Signed-off-by line: this documents who authored the change, you can read
more about the
The Developer's Certificate of Origin (chapter 11)
- if you are not used to the signed-off style, your contributions won't be rejected just because of it's missing, the Author: tag will be added as a substitute in order to allow contributions without much bothering with formalities
Documentation updates
Documentation fixes or updates do not need much explanation so sticking to the code rules in the previous section is not necessary. GitHub pull requests are OK, patches could be sent to me directly and not required to be also in the mailinglist. Pointing out typos via IRC also works, although might get accidentally lost in the noise.