Go to file
Qu Wenruo 8addcab0d0 btrfs-progs: Create uuid tree with proper contents
Commit 2a496a5b8b ("btrfs-progs: mkfs: precreate the uuid tree")
creates uuid tree at mkfs time.  However it doesn't populate uuid tree
correctly nor creates an empty root.

It uses create_tree(), which just
copies the content of fs root, containing a meaningless INODE_ITEM:

v4.15 mkfs (no uuid tree creation) + kernel mount:
  uuid tree key (UUID_TREE ROOT_ITEM 0)
  leaf 30572544 items 1 free space 16250 generation 7 owner UUID_TREE
  leaf 30572544 flags 0x1(WRITTEN) backref revision 1
  fs uuid 33ecddef-fc86-481a-93ce-846b01c11376
  chunk uuid 9e58f646-b0da-43ca-9c7d-8bbe3e120246
	item 0 key (0x92457c59d31491be UUID_KEY_SUBVOL 0xef908b5e79aa76a1) itemoff 16275 itemsize 8
		subvol_id 5

v4.19.1 mkfs (incorrect one), no kernel mount:
  uuid tree key (UUID_TREE ROOT_ITEM 0)
  leaf 30507008 items 2 free space 16061 generation 4 owner UUID_TREE
  leaf 30507008 flags 0x1(WRITTEN) backref revision 1
  fs uuid 162f5333-9b5d-4217-877c-ddaeaa79398e
  chunk uuid 7bc2c5c6-a6d2-4eec-a513-142b549c6541
	item 0 key (256 INODE_ITEM 0) itemoff 16123 itemsize 160
		generation 3 transid 0 size 0 nbytes 16384
		block group 0 mode 40755 links 1 uid 0 gid 0 rdev 0
		sequence 0 flags 0x0(none)
	item 1 key (256 INODE_REF 256) itemoff 16111 itemsize 12
		index 0 namelen 2 name: ..

This patchset will fix it by populuating uuid tree properly:
(NOTE: due to tree-checker, kernel doesn't accept empty uuid tree, so we
can only fix it by populating uuid tree correctly)

With this patchset, no kernel mount:
  uuid tree key (UUID_TREE ROOT_ITEM 0)
  leaf 30507008 items 1 free space 16250 generation 4 owner UUID_TREE
  leaf 30507008 flags 0x1(WRITTEN) backref revision 1
  fs uuid ae53079e-dbbc-409b-a565-5326c7b27731
  chunk uuid b5fb1bea-f20d-4af1-80f8-6ca3f0038d67
	item 0 key (0x334ba6b032d89c07 UUID_KEY_SUBVOL 0x86cde09cb78bcca0) itemoff 16275 itemsize 8
		subvol_id 5

For kernel, except tree-checker needs an non-empty uuid tree, both of
the above behavior won't cause problem, but it's always better to keep a
good standardized behavior.

Fixes: 2a496a5b8b ("btrfs-progs: mkfs: precreate the uuid tree")
Signed-off-by: Qu Wenruo <wqu@suse.com>
Signed-off-by: David Sterba <dsterba@suse.com>
2019-01-15 18:42:13 +01:00
Documentation btrfs-progs: docs: add bootloader support to section 5 2019-01-15 18:42:13 +01:00
check btrfs-progs: check: orig: Add ability to repair dir item with invalid hash 2019-01-15 18:42:13 +01:00
convert btrfs-progs: Add support for metadata_uuid field 2018-12-06 12:51:36 +01:00
image btrfs-progs: image: Only enlarge result image if it's a regular file 2019-01-15 18:42:12 +01:00
kernel-lib btrfs-progs: fix typos in comments 2018-11-26 18:24:48 +01:00
kernel-shared btrfs-progs: shared: cleanup includes in ulist.c 2017-03-08 13:00:47 +01:00
libbtrfsutil libbtrfsutil: fix unprivileged tests if kernel lacks support 2019-01-15 16:20:09 +01:00
m4 btrfs-progs: build: detect whether -std=gnu90 is supported 2018-06-07 16:37:35 +02:00
mkfs btrfs-progs: Create uuid tree with proper contents 2019-01-15 18:42:13 +01:00
tests btrfs-progs: tests: speed up fsck/037 free space tree test 2019-01-15 18:42:13 +01:00
travis btrfs-progs: tests: pull zstd version 1.3.7 to the travis CI 2018-11-26 17:26:51 +01:00
.gitignore btrfs-progs: clean up .gitignore 2018-10-23 14:48:39 +02:00
.travis.yml btrfs-progs: ci: enable clang and python for musl build test 2018-03-06 11:28:38 +01:00
64-btrfs-dm.rules btrfs-progs: udev: add rules for dm devices 2016-06-01 14:56:56 +02:00
Android.mk btrfs-progs: build: Remove unused variable TESTS 2018-01-08 19:25:05 +01:00
CHANGES btrfs-progs: update CHANGES for v4.19.1 2018-12-05 15:04:23 +01:00
COPYING fix COPYING 2007-06-12 15:41:08 -04:00
INSTALL btrfs-progs: docs: fix typos in READMEs, INSTALL and CHANGES 2018-11-26 17:47:22 +01:00
Makefile btrfs-progs: silence build warning caused by gcc 8 '-Wformat-truncation' 2019-01-15 16:20:10 +01:00
Makefile.extrawarn btrfs-progs: Makefile.extrawarn: Don't warn on sign compare 2019-01-15 16:20:10 +01:00
Makefile.inc.in btrfs-progs: build: add --disable-shared and --disable-static 2018-08-06 15:03:41 +02:00
README.md btrfs-progs: docs: fix typos in READMEs, INSTALL and CHANGES 2018-11-26 17:47:22 +01:00
VERSION Btrfs progs v4.19.1 2018-12-05 15:05:38 +01:00
androidcompat.h btrfs-progs: add compat header for android 2015-09-01 14:02:49 +02:00
autogen.sh btrfs-progs: build: simplify version tracking 2018-01-31 15:14:01 +01:00
backref.c btrfs-progs: do not merge tree block refs have different root_id 2018-06-07 16:37:36 +02:00
backref.h btrfs-progs: move ulist.[ch] to kernel-shared 2017-03-08 13:00:47 +01:00
bcp Btrfs-progs: Correct path munging in bcp 2011-10-25 09:18:58 -04:00
btrfs-completion btrfs-progs: completion: let dump-tree/dump-super/inode-resolve accept any file 2018-10-23 14:48:38 +02:00
btrfs-corrupt-block.c btrfs-progs: convert strerror to implicit %m 2018-10-31 18:24:14 +01:00
btrfs-crc.c btrfs-progs: btrfs-crc: make argc check more strict 2016-06-03 14:49:43 +02:00
btrfs-debugfs btrfs-progs: right-align number columns in btrfs-debugfs output 2017-10-06 13:41:31 +02:00
btrfs-find-root.c btrfs-progs: convert strerror to implicit %m 2018-10-31 18:24:14 +01:00
btrfs-fragments.c btrfs-progs: use symbolic tree name when searching 2016-11-09 13:47:29 +01:00
btrfs-list.c btrfs-progs: convert strerror to implicit %m 2018-10-31 18:24:14 +01:00
btrfs-list.h btrfs-progs: fix typo in btrfs-list function export 2018-11-26 18:24:49 +01:00
btrfs-map-logical.c btrfs-progs: convert strerror to implicit %m 2018-10-31 18:24:14 +01:00
btrfs-sb-mod.c btrfs-progs: sb-mod: add compat bit to the recognized fields 2018-04-11 15:37:36 +02:00
btrfs-select-super.c btrfs-progs: fix typos in user-visible strings 2018-11-26 18:24:49 +01:00
btrfs.c btrfs-progs: fix typos in comments 2018-11-26 18:24:48 +01:00
btrfsck.h btrfs-progs: check: fix typo in device_extent_record::chunk_objectid 2018-11-26 18:24:49 +01:00
btrfstune.c btrfs-progs: Directly pass root to change_devices_uuid 2019-01-15 16:20:09 +01:00
chunk-recover.c btrfs-progs: Introduce rescue.h to resolve missing-prototypes for chunk and super rescue 2019-01-15 18:42:12 +01:00
cmds-balance.c btrfs-progs: docs: fix balance -f grammar 2019-01-15 18:42:12 +01:00
cmds-device.c btrfs-progs: convert strerror to implicit %m 2018-10-31 18:24:14 +01:00
cmds-fi-du.c btrfs-progs: convert strerror to implicit %m 2018-10-31 18:24:14 +01:00
cmds-fi-usage.c btrfs-progs: Fix wrong optind re-initialization to allow mixed option and non-option 2018-08-06 14:59:45 +02:00
cmds-fi-usage.h btrfs-progs: don't use __u8 for fsid buffers 2017-11-14 15:59:00 +01:00
cmds-filesystem.c btrfs-progs: Add support for metadata_uuid field 2018-12-06 12:51:36 +01:00
cmds-inspect-dump-super.c btrfs-progs: Add support for metadata_uuid field 2018-12-06 12:51:36 +01:00
cmds-inspect-dump-tree.c btrfs-progs: print-tree: Use bool for @follow 2018-10-31 18:24:14 +01:00
cmds-inspect-tree-stats.c btrfs-progs: convert strerror to implicit %m 2018-10-31 18:24:14 +01:00
cmds-inspect.c btrfs-progs: convert strerror to implicit %m 2018-10-31 18:24:14 +01:00
cmds-property.c btrfs-progs: convert strerror to implicit %m 2018-10-31 18:24:14 +01:00
cmds-qgroup.c btrfs-progs: qgroup: make --rescan the default behavior after assign 2018-10-31 18:24:14 +01:00
cmds-quota.c btrfs-progs: Fix wrong optind re-initialization to allow mixed option and non-option 2018-08-06 14:59:45 +02:00
cmds-receive.c btrfs-progs: convert strerror to implicit %m 2018-10-31 18:24:14 +01:00
cmds-replace.c btrfs-progs: convert strerror to implicit %m 2018-10-31 18:24:14 +01:00
cmds-rescue.c btrfs-progs: Introduce rescue.h to resolve missing-prototypes for chunk and super rescue 2019-01-15 18:42:12 +01:00
cmds-restore.c btrfs-progs: Replace root parameter using fs_info for reada_for_search() 2018-10-31 18:24:14 +01:00
cmds-scrub.c btrfs-progs: convert strerror to implicit %m 2018-10-31 18:24:14 +01:00
cmds-send.c btrfs-progs: convert strerror to implicit %m 2018-10-31 18:24:14 +01:00
cmds-subvolume.c btrfs-progs: docs: enhance subvol show documentation and help 2019-01-15 18:42:13 +01:00
commands.h btrfs-progs: move command definitions to commands.h 2017-08-24 19:08:24 +02:00
common-defs.h btrfs-progs: move some common definitions to own header 2017-03-08 13:00:45 +01:00
configure.ac btrfs-progs: fix typos in user-visible strings 2018-11-26 18:24:49 +01:00
ctree.c btrfs-progs: Fix -Wmaybe-uninitialized warning 2019-01-15 18:42:12 +01:00
ctree.h btrfs-progs: uuid: Port btrfs_uuid_tree_add() function 2019-01-15 18:42:13 +01:00
delayed-ref.c btrfs-progs: kerncompat: rename swap to __swap 2018-11-13 13:33:15 +01:00
delayed-ref.h btrfs-progs: Add delayed refs infrastructure 2018-10-23 14:48:41 +02:00
dir-item.c btrfs-progs: check: lowmem: Add ability to repair dir item with mismatched hash 2019-01-15 18:42:13 +01:00
disk-io.c btrfs-progs: uuid: Port btrfs_uuid_tree_add() function 2019-01-15 18:42:13 +01:00
disk-io.h btrfs-progs: mkfs: Create data reloc tree from scratch 2019-01-15 18:42:13 +01:00
extent-cache.c btrfs-progs: Remove objectid argument from alloc_cache_extent 2018-06-07 16:37:32 +02:00
extent-cache.h btrfs-progs: Remove add_cache_extent2 2018-06-07 16:37:32 +02:00
extent-tree.c btrfs-progs: treewide: Fix missing declarations 2018-11-13 13:32:41 +01:00
extent_io.c btrfs-progs: Add extent buffer bitmap manipulation infrastructure 2018-10-23 15:46:33 +02:00
extent_io.h btrfs-progs: Add extent buffer bitmap manipulation infrastructure 2018-10-23 15:46:33 +02:00
file-item.c btrfs-progs: Remove root argument from btrfs_del_csums 2018-08-06 15:01:46 +02:00
file.c btrfs-progs: fix typos in comments 2018-11-26 18:24:48 +01:00
find-root.c btrfs-progs: drop blocksize from read_tree_block 2017-09-08 16:15:05 +02:00
find-root.h btrfs-progs: find-root: Allow btrfs-find-root to search chunk root even chunk root is corrupted 2016-02-26 17:27:58 +01:00
free-space-cache.c btrfs-progs: free-space-cache: Don't panic when free space cache is corrupted 2018-08-06 15:00:24 +02:00
free-space-cache.h btrfs-progs: check: add support to clear v1 free space cache 2016-11-09 13:12:47 +01:00
free-space-tree.c btrfs-progs: Export btrfs_create_tree() and move it to disk-io.c 2019-01-15 18:42:13 +01:00
free-space-tree.h btrfs-progs: Pull free space tree related code from kernel 2018-10-25 16:11:39 +02:00
fsck.btrfs btrfs-progs: fsck.btrfs: Fix bashism and bad getopts processing 2015-05-21 16:53:44 +02:00
fsfeatures.c btrfs-progs: Move btrfs_check_nodesize to fsfeatures.c to fix missing-prototypes warning 2019-01-15 18:42:12 +01:00
fsfeatures.h btrfs-progs: Add zstd support 2017-09-25 15:17:13 +02:00
hash.h btrfs-progs: move btrfs_extref_hash() to hash.h 2016-10-25 14:28:36 +02:00
hasher.c Unaligned access fixes 2008-02-15 11:19:58 -05:00
help.c btrfs-progs: fix typos in comments 2018-11-26 18:24:48 +01:00
help.h btrfs-progs: Remove unused parameter 2018-03-30 22:15:55 +02:00
inode-item.c btrfs-progs: remove unused argument from btrfs_lookup_inode_ref 2017-03-08 13:00:47 +01:00
inode-map.c btrfs-progs: handle errors from btrfs_alloc_path 2016-09-21 14:12:38 +02:00
inode.c btrfs-progs: check: adjustments for further repair 2017-10-16 20:33:00 +02:00
internal.h btrfs-progs: libbtrfs: remove max/min macros from API 2016-03-14 13:42:47 +01:00
ioctl-test.c btrfs-progs: tests: make the ioctl-test actually useful 2016-10-24 14:57:19 +02:00
ioctl.h btrfs-progs: ioctl/libbtrfsutil: add 3 definitions of new unprivileged ioctl 2018-10-31 18:24:14 +01:00
kerncompat.h btrfs-progs: kerncompat: rename swap to __swap 2018-11-13 13:33:15 +01:00
library-test.c btrfs-progs: library-test: add all exported headers 2017-03-31 14:17:48 +02:00
messages.c btrfs-progs: add prefix to message helpers 2017-03-31 14:17:48 +02:00
messages.h btrfs-progs: Fix Wempty-body warning 2019-01-15 18:42:12 +01:00
print-tree.c btrfs-progs: fix typos in comments 2018-11-26 18:24:48 +01:00
print-tree.h btrfs-progs: print-tree: Use bool for @follow 2018-10-31 18:24:14 +01:00
props.c btrfs-progs: convert strerror to implicit %m 2018-10-31 18:24:14 +01:00
props.h btrfs-progs: unify header file inclusion protections 2015-01-21 17:49:26 +01:00
qgroup-verify.c btrfs-progs: fix typos in user-visible strings 2018-11-26 18:24:49 +01:00
qgroup-verify.h btrfs-progs: check: enhanced progress indicator 2018-08-06 15:03:23 +02:00
qgroup.c btrfs-progs: convert strerror to implicit %m 2018-10-31 18:24:14 +01:00
qgroup.h btrfs-progs: remove unused function btrfs_get_path_rootid 2016-11-09 13:47:28 +01:00
quick-test.c btrfs-progs: fix build of quick-test 2018-08-06 15:01:36 +02:00
random-test.c btrfs-progs: add crude error handling when transaction start fails 2017-09-08 16:15:05 +02:00
rbtree-utils.c Btrfs-progs: break out rbtree util functions 2014-10-14 10:39:39 +02:00
rbtree-utils.h btrfs-progs: libbtrfs, make exported headers compatible with C++ 2014-11-03 23:50:50 +01:00
repair.c btrfs-progs: factor out repair mode 2016-07-04 15:22:53 +02:00
repair.h btrfs-progs: factor out repair mode 2016-07-04 15:22:53 +02:00
rescue.h btrfs-progs: Introduce rescue.h to resolve missing-prototypes for chunk and super rescue 2019-01-15 18:42:12 +01:00
root-tree.c btrfs-progs: Use more strict check to read out tree root 2017-05-02 16:33:04 +02:00
send-dump.c btrfs-progs: fix typos in comments 2018-11-26 18:24:48 +01:00
send-dump.h btrfs-progs: introduce new send-dump object 2016-12-14 15:06:34 +01:00
send-stream.c btrfs-progs: Fix -Wtype-limits warning 2019-01-15 16:20:10 +01:00
send-stream.h btrfs-progs: add missing includes to header files 2015-06-10 02:52:21 +02:00
send-utils.c btrfs-progs: convert strerror to implicit %m 2018-10-31 18:24:14 +01:00
send-utils.h btrfs-progs: send-utils: remove unused functions path_cat and path_cat3 2018-04-24 13:00:03 +02:00
send.h btrfs-progs: Introduce kernel sizes to cleanup large intermediate number 2017-03-08 13:00:45 +01:00
show-blocks btrfs-progs: Remove btrfs-debug-tree command 2018-04-24 13:00:10 +02:00
string-table.c btrfs-progs: Fix -Wsuggest-attribute=format warning 2019-01-15 16:20:10 +01:00
string-table.h btrfs-progs: constify string arguments where appropriate 2016-10-03 15:07:23 +02:00
super-recover.c btrfs-progs: Introduce rescue.h to resolve missing-prototypes for chunk and super rescue 2019-01-15 18:42:12 +01:00
task-utils.c btrfs-progs: task-utils: Fix comparison between pointer and integer 2018-11-13 13:22:19 +01:00
task-utils.h btrfs-progs: check: enhanced progress indicator 2018-08-06 15:03:23 +02:00
transaction.c btrfs-progs: fix typos in user-visible strings 2018-11-26 18:24:49 +01:00
transaction.h btrfs-progs: Add delayed refs infrastructure 2018-10-23 14:48:41 +02:00
utils-lib.c btrfs-progs: Add utils.h include to solve missing-prototypes warning 2019-01-15 18:42:12 +01:00
utils.c btrfs-progs: Move btrfs_check_nodesize to fsfeatures.c to fix missing-prototypes warning 2019-01-15 18:42:12 +01:00
utils.h btrfs-progs: treewide: Fix missing declarations 2018-11-13 13:32:41 +01:00
uuid-tree.c btrfs-progs: uuid: Port btrfs_uuid_tree_add() function 2019-01-15 18:42:13 +01:00
version.h.in btrfs-progs: re-introduce BTRFS_BUILD_VERSION in version.h 2015-03-16 18:40:06 +01:00
volumes.c btrfs-progs: Remove fsid/metdata_uuid fields from fs_info 2019-01-15 16:20:09 +01:00
volumes.h btrfs-progs: Add support for metadata_uuid field 2018-12-06 12:51:36 +01:00

README.md

Btrfs-progs build status coverity status

Userspace utilities to manage btrfs filesystems. License: GPLv2.

Btrfs is a copy on write (COW) filesystem for Linux aimed at implementing advanced features while focusing on fault tolerance, repair and easy administration.

This repository hosts following utilities:

  • btrfs — the main administration tool (manual page)
  • mkfs.btrfs — utility to create the filesystem (manual page)

The C and python 3 bindings are provided by a LGPL library libbtrfsutil see libbtrfsutil/README.md for more.

See INSTALL for build instructions and tests/README.md for testing information.

Release cycle

The major version releases are time-based and follow the cycle of the linux kernel releases. The cycle usually takes 2 months. A minor version releases may happen in the meantime if there are bug fixes or minor useful improvements queued.

The release tags are signed with a GPG key ID F2B4 1200 C54E FB30 380C 1756 C565 D5F9 D76D 583B, release tarballs are hosted at kernel.org. See file CHANGES or changelogs on wiki.

Reporting bugs

There are several ways, each has its own specifics and audience that can give feedback or work on a fix. The following list is sorted in the order of preference:

  • github issue tracker
  • to the mailing list linux-btrfs@vger.kernel.org -- (not required to subscribe), beware that the mail might get overlooked in other traffic
  • IRC (irc.freenode.net #btrfs) -- good for discussions eg. if a bug is already known, but reports could miss developers' attention
  • bugzilla.kernel.org -- (requires registration), set the product to Filesystems and component Btrfs, please put 'btrfs-progs' into the subject so it's clear that it's not a kernel bug report

Development

The patch submissions, development or general discussions take place at linux-btrfs@vger.kernel.org mailinglist, subsciption is not required to post.

The GitHub pull requests will not be accepted directly, the preferred way is to send patches to the mailinglist instead. You can link to a branch in any git repository if the mails do not make it to the mailinglist or just for convenience (makes it easier to test).

The development model of btrfs-progs shares a lot with the kernel model. The github way is different in some ways. We, the upstream community, expect that the patches meet some criteria (often lacking in github contributions):

  • one logical change per patch: eg. not mixing bugfixes, cleanups, features etc., sometimes it's not clear and will be usually pointed out during reviews
  • proper subject line: eg. prefix with btrfs-progs: subpart, ... , descriptive yet not too long, see git log --oneline for some inspiration
  • proper changelog: the changelogs are often missing or lacking explanation why the change was made, or how is something broken, what are user-visible effects of the bug or the fix, how does an improvement help or the intended usecase
  • the Signed-off-by line: this documents who authored the change, you can read more about the The Developer's Certificate of Origin (chapter 11)
    • if you are not used to the signed-off style, your contributions won't be rejected just because of it's missing, the Author: tag will be added as a substitute in order to allow contributions without much bothering with formalities

Documentation updates

Documentation fixes or updates do not need much explanation so sticking to the code rules in the previous section is not necessary. GitHub pull requests are OK, patches could be sent to me directly and not required to be also in the mailinglist. Pointing out typos via IRC also works, although might get accidentally lost in the noise.

References