33f07b0d03
btrfs-progs: convert: use on-stack path buffer in link_subvol
...
We don't need to conserve stack space too much unlike kernel, also
remove one error condition.
Signed-off-by: David Sterba <dsterba@suse.com>
2016-11-09 13:47:31 +01:00
c0807cbfc4
btrfs-progs: convert: use on-stack path buffer in create_image
...
We don't need to conserve stack space too much unlike kernel, also
remove one error condition.
Signed-off-by: David Sterba <dsterba@suse.com>
2016-11-09 13:47:31 +01:00
aca69c9d39
btrfs-progs: convert: use on-stack path buffer in record_file_blocks
...
We don't need to conserve stack space too much unlike kernel, also
remove one error condition.
Signed-off-by: David Sterba <dsterba@suse.com>
2016-11-09 13:47:31 +01:00
a34b3b9273
btrfs-progs: mkfs: use on-stack path buffer in cleanup_temp_chunks
...
We don't need to conserve stack space too much unlike kernel, also
remove one error condition.
Signed-off-by: David Sterba <dsterba@suse.com>
2016-11-09 13:47:31 +01:00
5a0645afb8
btrfs-progs: reduce size of btrfs_path::lowest_level
...
Signed-off-by: David Sterba <dsterba@suse.com>
2016-11-09 13:47:31 +01:00
f0f40c400e
btrfs-progs: reduce size of btrfs_path::reada
...
We use only a few values, reada accessed not in performance critical
contexts.
Signed-off-by: David Sterba <dsterba@suse.com>
2016-11-09 13:47:31 +01:00
b81edabe79
btrfs-progs: reduce size of btrfs_path, locks are not used
...
Size of btrfs_path can be reduced by 32 bytes as we don't use the locks
array, down to 112 from 144 bytes.
Signed-off-by: David Sterba <dsterba@suse.com>
2016-11-09 13:47:31 +01:00
7456592977
btrfs-progs: mkfs: constify some char parameters
...
Signed-off-by: David Sterba <dsterba@suse.com>
2016-11-09 13:47:31 +01:00
8ade920c5b
btrfs-progs: mkfs: use const char for unmodified members of directory_name_entry
...
We never modify the members, just point them to other strings.
Signed-off-by: David Sterba <dsterba@suse.com>
2016-11-09 13:47:31 +01:00
87596654ae
btrfs-progs: check: reorder fields in inode_backref for better packing
...
The structure size went from 56 bytes to 48, which could save some bytes
in larger scale.
Signed-off-by: David Sterba <dsterba@suse.com>
2016-11-09 13:47:31 +01:00
35985c1521
btrfs-progs: check: unify type for inode_backref::itemtype
...
Signed-off-by: David Sterba <dsterba@suse.com>
2016-11-09 13:47:31 +01:00
b759702b67
btrfs-progs: check: unify type for inode_backref::filetype
...
Signed-off-by: David Sterba <dsterba@suse.com>
2016-11-09 13:47:31 +01:00
17a8c6d7e1
btrfs-progs: send: cleanup use of ctransid delta temporary variable in find_good_parent
...
Signed-off-by: David Sterba <dsterba@suse.com>
2016-11-09 13:47:31 +01:00
62fb1a5c14
btrfs-progs: send: cleanup, rename send context variables
...
Signed-off-by: David Sterba <dsterba@suse.com>
2016-11-09 13:47:31 +01:00
a9f407b9a6
btrfs-progs: send: cleanup, rename some variables in dump_thread
...
Signed-off-by: David Sterba <dsterba@suse.com>
2016-11-09 13:47:31 +01:00
f3a00c630a
btrfs-progs: send: clean types in write_buf
...
Use matching types for buffer, return value and buffer sizes.
Signed-off-by: David Sterba <dsterba@suse.com>
2016-11-09 13:47:31 +01:00
aec1d7fa8b
btrfs-progs: send: use proper type for read result, and rename the variable
...
Signed-off-by: David Sterba <dsterba@suse.com>
2016-11-09 13:47:31 +01:00
76fc07e3a6
btrfs-progs: send: increase size of transfer buffer
...
4K is quite small, increase it to 64K. This reduces number of
context switches and calls to read. Kernel sends us about 50K of data
per read, so increasing the buffer further does not make any
improvement.
Example run on tests/cli-tests/004-send-parent-multi-subvol:
4K:
- ~800 context switches
- ~5000 calls to read
64K:
- ~450 context switches
- ~500 calls to read
Signed-off-by: David Sterba <dsterba@suse.com>
2016-11-09 13:47:31 +01:00
88edac358c
btrfs-progs: send: constify some arugments
...
Signed-off-by: David Sterba <dsterba@suse.com>
2016-11-09 13:47:30 +01:00
29a1a78aaa
btrfs-progs: tests: add test for multi-subvolume send from parent
...
Fixed by "btrfs-progs: send: fix handling of multiple snapshots (-p
option)".
Signed-off-by: David Sterba <dsterba@suse.com>
2016-11-09 13:47:30 +01:00
b9ff0190cf
btrfs-progs: dump-tree: convert dir-item-to-string to table
...
Signed-off-by: David Sterba <dsterba@suse.com>
2016-11-09 13:47:30 +01:00
e6410f631d
btrfs-progs: dump-tree: convert key-to-string to table
...
Signed-off-by: David Sterba <dsterba@suse.com>
2016-11-09 13:47:30 +01:00
69f879eac9
btrfs-progs: dump-tree: cleanup types for item number iteration
...
Signed-off-by: David Sterba <dsterba@suse.com>
2016-11-09 13:47:30 +01:00
56917b41fb
btrfs-progs: dump-tree: move remaining item variables to the scope of use
...
Signed-off-by: David Sterba <dsterba@suse.com>
2016-11-09 13:47:30 +01:00
e58cc23823
btrfs-progs: dump-tree: move variable declarations closer to their use
...
Signed-off-by: David Sterba <dsterba@suse.com>
2016-11-09 13:47:30 +01:00
6b138f5367
btrfs-progs: dump-tree: rename extent buffer variable in btrfs_print_leaf
...
Signed-off-by: David Sterba <dsterba@suse.com>
2016-11-09 13:47:30 +01:00
7541b53b34
btrfs-progs: dump-tree: add untyped item ptr helper and use it
...
There's lots of code that passes btrfs_item_ptr. Add a helper to extract
the ptr at the beginning, ignoring the type. The print functions take
the correct type, but we ignore it in the conversion macros as it does
not provide the type checking anyway.
If the typed variable is used more than once, it's kept in place.
Signed-off-by: David Sterba <dsterba@suse.com>
2016-11-09 13:47:30 +01:00
17a9d9013d
btrfs-progs: dump-tree: constify char argument in print_root_ref
...
Signed-off-by: David Sterba <dsterba@suse.com>
2016-11-09 13:47:30 +01:00
a15294f0c4
btrfs-progs: dump-tree: simplify and fix check for empty uuid
...
Counting non-zero bytes is wasteful, besides that it would not recognize
uuids containing a 00 value.
Signed-off-by: David Sterba <dsterba@suse.com>
2016-11-09 13:47:30 +01:00
5082ec84a8
btrfs-progs: dump-tree: return void from print_* functions
...
Signed-off-by: David Sterba <dsterba@suse.com>
2016-11-09 13:47:30 +01:00
e9c1121495
btrfs-progs: dump-tree: pass item size instead of item
...
Several functions take item but use just the size, we can factor the
item size and use that.
Signed-off-by: David Sterba <dsterba@suse.com>
2016-11-09 13:47:30 +01:00
ae00d4a251
btrfs-progs: remove unused parameter from print_inode_item
...
Signed-off-by: David Sterba <dsterba@suse.com>
2016-11-09 13:47:30 +01:00
15db981600
btrfs-progs: dump-tree: consolidate data key names
...
Rename to the structure members, add underscore so it's a single word.
Compression is also printed as raw value.
Signed-off-by: David Sterba <dsterba@suse.com>
2016-11-09 13:47:30 +01:00
cf5c55fba8
btrfs-progs: dump-tree: print dev stats
...
Signed-off-by: David Sterba <dsterba@suse.com>
2016-11-09 13:47:30 +01:00
0f4ab474fe
btrfs-progs: add dev stats on-disk structure
...
Signed-off-by: David Sterba <dsterba@suse.com>
2016-11-09 13:47:30 +01:00
b74dbb86c0
btrfs-progs: dump-tree: print balance status item
...
Signed-off-by: David Sterba <dsterba@suse.com>
2016-11-09 13:47:30 +01:00
ad5c75708a
btrfs-progs: add balance status structures
...
Signed-off-by: David Sterba <dsterba@suse.com>
2016-11-09 13:47:30 +01:00
8a50dc9600
btrfs-progs: teach print_leaf about temporary item subtypes
...
[ kernel patch 9f07e1d76eaeeddedcf9651395b4a8f870df31f0 ]
Signed-off-by: David Sterba <dsterba@suse.com>
2016-11-09 13:47:30 +01:00
9da5b472d5
btrfs-progs: teach print_leaf about permanent item subtypes
...
[ kernel patch 585a3d0d238dfe42909cb58b0d05f644365fed14 ]
Signed-off-by: David Sterba <dsterba@suse.com>
2016-11-09 13:47:30 +01:00
2add123c8e
btrfs-progs: switch dev stats item to the permanent item key
...
[ kernel patch 242e2956e4afde7727fffe21adc0a7b198b77f96 ]
Signed-off-by: David Sterba <dsterba@suse.com>
2016-11-09 13:47:30 +01:00
e244550b42
btrfs-progs: introduce key type for persistent permanent items
...
The number of distinct key types is not that big that we could waste one
for something new we want to store in the tree.
Similar to the temporary items, we'll introduce a new name for an
existing key value and use the objectid for further extension. The
victim is the BTRFS_DEV_STATS_KEY (248).
The device stats are an example of a permanent item.
[ kernel patch 50c2d5abe64c1726b48d292a2ab04f60e8238933 ]
Signed-off-by: David Sterba <dsterba@suse.com>
2016-11-09 13:47:30 +01:00
e905d055f6
btrfs-progs: print-tree: extract offset from the item key
...
Signed-off-by: David Sterba <dsterba@suse.com>
2016-11-09 13:47:30 +01:00
6122cb32c6
btrfs-progs: introduce key type for persistent temporary items
...
The number of distinct key types is not that big that we could waste one
for something new we want to store in the tree. We'll introduce a new
name for an existing key value and use the objectid for further
extension. The victim is the BTRFS_BALANCE_ITEM_KEY (248).
The nature of the balance status item is a good example of the temporary
item. It exists from beginning of the balance, keeps the status until it
finishes.
[ kernel patch 0bbbccb17fea86818e1a058faf5903aefd20b31a ]
Signed-off-by: David Sterba <dsterba@suse.com>
2016-11-09 13:47:30 +01:00
5c4d53450b
btrfs-progs: mkfs: store creation time of the toplevel subvolume
...
For unkonwn reasons, the creation time of the toplevel subvolume inode
item hasn't been set.
Signed-off-by: David Sterba <dsterba@suse.com>
2016-11-09 13:47:30 +01:00
5d43dfd344
btrfs-progs: dump-tree: print missing data for file extent item
...
Signed-off-by: David Sterba <dsterba@suse.com>
2016-11-09 13:47:30 +01:00
069b0b6d14
btrfs-progs: dump-tree: print more root_item data
...
Print a few more missing items of root_item (there are still some
remaining). Drop key is printend unconditionally.
Signed-off-by: David Sterba <dsterba@suse.com>
2016-11-09 13:47:29 +01:00
58bef5b4a7
btrfs-progs: dump-tree: print missing dir_item data
...
Add items from dir_item that are not printed, plus other adjustments.
Signed-off-by: David Sterba <dsterba@suse.com>
2016-11-09 13:47:29 +01:00
6c849c616e
btrfs-progs: dump-tree: print missing inode_item data
...
Add items from inode_item that are not printed.
Signed-off-by: David Sterba <dsterba@suse.com>
2016-11-09 13:47:29 +01:00
f1d4606a6d
btrfs-progs: dump-tree: add helper to print timespec
...
Signed-off-by: David Sterba <dsterba@suse.com>
2016-11-09 13:47:29 +01:00
58fe71f3f7
btrfs-progs: dump-tree: factor inode_item dump to function
...
Signed-off-by: David Sterba <dsterba@suse.com>
2016-11-09 13:47:29 +01:00
David Sterba