From f73c5e075ea49d25a862686ac036024a5e82ad50 Mon Sep 17 00:00:00 2001 From: David Sterba Date: Thu, 3 Nov 2016 00:37:51 +0100 Subject: [PATCH] btrfs-progs: check: use on-stack path buffer in check_fs_first_inode We don't need to conserve stack space too much unlike kernel, also remove one error condition. Signed-off-by: David Sterba --- cmds-check.c | 12 +++++------- 1 file changed, 5 insertions(+), 7 deletions(-) diff --git a/cmds-check.c b/cmds-check.c index fceaec43..4cd0fcd0 100644 --- a/cmds-check.c +++ b/cmds-check.c @@ -4934,19 +4934,17 @@ out: static int check_fs_first_inode(struct btrfs_root *root, unsigned int ext_ref) { - struct btrfs_path *path; + struct btrfs_path path; struct btrfs_key key; int err = 0; int ret; - path = btrfs_alloc_path(); - if (!path) - return -ENOMEM; + btrfs_init_path(&path); key.objectid = BTRFS_FIRST_FREE_OBJECTID; key.type = BTRFS_INODE_ITEM_KEY; key.offset = 0; - ret = btrfs_search_slot(NULL, root, &key, path, 0, 0); + ret = btrfs_search_slot(NULL, root, &key, &path, 0, 0); if (ret < 0) goto out; if (ret > 0) { @@ -4954,12 +4952,12 @@ static int check_fs_first_inode(struct btrfs_root *root, unsigned int ext_ref) err |= INODE_ITEM_MISSING; } - err |= check_inode_item(root, path, ext_ref); + err |= check_inode_item(root, &path, ext_ref); err &= ~LAST_ITEM; if (err && !ret) ret = -EIO; out: - btrfs_free_path(path); + btrfs_release_path(&path); return ret; }