From c052b38418f99fe1ed9887ecfd7b730421d4913f Mon Sep 17 00:00:00 2001 From: Marcos Paulo de Souza Date: Mon, 21 Oct 2019 23:02:28 -0300 Subject: [PATCH] btrfs-progs: Makefile: Add -Wimplicit-fallthrough Avoid introducing new cases of implicit fallthrough by having this flag always set, though a conditional check is needed to avoid build breakage on older compilers or on CI. Reviewed-by: Nikolay Borisov Signed-off-by: Marcos Paulo de Souza Signed-off-by: David Sterba --- Makefile | 4 ++++ 1 file changed, 4 insertions(+) diff --git a/Makefile b/Makefile index d6076337..f581ce2c 100644 --- a/Makefile +++ b/Makefile @@ -78,6 +78,9 @@ TOPDIR := . DISABLE_WARNING_FLAGS := $(call cc-disable-warning, format-truncation) \ $(call cc-disable-warning, address-of-packed-member) +# Warnings that we want by default +ENABLE_WARNING_FLAGS := $(call cc-option, -Wimplicit-fallthrough) + # Common build flags CFLAGS = $(SUBST_CFLAGS) \ $(CSTD) \ @@ -89,6 +92,7 @@ CFLAGS = $(SUBST_CFLAGS) \ -I$(TOPDIR) \ -I$(TOPDIR)/libbtrfsutil \ $(DISABLE_WARNING_FLAGS) \ + $(ENABLE_WARNING_FLAGS) \ $(EXTRAWARN_CFLAGS) \ $(DEBUG_CFLAGS_INTERNAL) \ $(EXTRA_CFLAGS)