marko10_000
/
btrfs-progs
forked from Mirrors/btrfs-progs
1
0
Fork 0
Code Issues Pull Requests Releases Wiki Activity

btrfs-progs: prop: simplify parse_args() 

Since <object> parameter is mandatory for all subcommands,
'object' is always set by parse_args()'s callers.
In addition, on setting '*name' and '*value', if 'optind < argc'
is satisfied here, they are always set by parse_args()'s callers.

Signed-off-by: Satoru Takeuchi <takeuchi_satoru@jp.fujitsu.com>
Signed-off-by: David Sterba <dsterba@suse.com>
master
Satoru Takeuchi 2016-05-09 16:49:19 +09:00 committed by David Sterba
parent b72438362b
commit ad474ff50c
1 changed files with 5 additions and 8 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

13
cmds-property.c
View File

@ -298,7 +298,7 @@ static void parse_args(int argc, char **argv,
{
int ret;
char *type_str = NULL;
int max_nonopt_args = 0;
int max_nonopt_args = 1;
optind = 1;
while (1) {
@ -315,8 +315,6 @@ static void parse_args(int argc, char **argv,
}
}
if (object)
max_nonopt_args++;
if (name)
max_nonopt_args++;
if (value)
@ -345,14 +343,13 @@ static void parse_args(int argc, char **argv,
}
}
if (object && optind < argc)
*object = argv[optind++];
if (name && optind < argc)
*object = argv[optind++];
if (optind < argc)
*name = argv[optind++];
if (value && optind < argc)
if (optind < argc)
*value = argv[optind++];
if (!*types && object && *object) {
if (!*types) {
ret = autodetect_object_types(*object, types);
if (ret < 0) {
error("failed to detect object type: %s",