From 9dc137918f3a3346bb2c6ef3de6033d5688c037b Mon Sep 17 00:00:00 2001 From: Eric Sandeen Date: Wed, 6 Nov 2013 17:15:44 -0600 Subject: [PATCH] btrfs-progs: don't leak fd in test_dev_for_mkfs() error paths Close fd before we return on error paths. Resolves-Coverity-CID: 1125939 Signed-off-by: Eric Sandeen Reviewed-by: Anand Jain Signed-off-by: Chris Mason --- utils.c | 2 ++ 1 file changed, 2 insertions(+) diff --git a/utils.c b/utils.c index 47ba23b6..9af49f70 100644 --- a/utils.c +++ b/utils.c @@ -1928,10 +1928,12 @@ int test_dev_for_mkfs(char *file, int force_overwrite, char *estr) if (fstat(fd, &st)) { snprintf(estr, sz, "unable to stat %s: %s\n", file, strerror(errno)); + close(fd); return 1; } if (!S_ISBLK(st.st_mode)) { fprintf(stderr, "'%s' is not a block device\n", file); + close(fd); return 1; } close(fd);