marko10_000
/
btrfs-progs
forked from Mirrors/btrfs-progs
1
0
Fork 0
Code Issues Pull Requests Releases Wiki Activity

btrfs-progs: mkfs: fix reading rotational status value 

ASAN reports that we're reading beyond the bounds, and is right. The
variable is too short to store a nonempty string for atoi.

Signed-off-by: David Sterba <dsterba@suse.com>
master
David Sterba 2016-09-21 13:36:04 +02:00
parent d75e061bcd
commit 90e3e630c2
1 changed files with 2 additions and 2 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

4
mkfs.c
View File

@ -1193,13 +1193,13 @@ static int is_ssd(const char *file)
return 0;
}
if (read(fd, &rotational, sizeof(char)) < sizeof(char)) {
if (read(fd, &rotational, 1) < 1) {
close(fd);
return 0;
}
close(fd);
return !atoi((const char *)&rotational);
return rotational == '0';
}
static int _cmp_device_by_id(void *priv, struct list_head *a,