marko10_000
/
btrfs-progs
forked from Mirrors/btrfs-progs
1
0
Fork 0
Code Issues Pull Requests Releases Wiki Activity

btrfs-progs: use on-stack buffer in add_symbolic_link 

Also get rid of the unhandled memory allocation.

Resolves-coverity-id: 1338298
Signed-off-by: David Sterba <dsterba@suse.com>
master
David Sterba 2016-01-06 14:22:34 +01:00
parent 2cb9b4dbbd
commit 8b5147d5f3
1 changed files with 3 additions and 5 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

8
mkfs.c
View File

@ -591,15 +591,14 @@ static int add_symbolic_link(struct btrfs_trans_handle *trans,
u64 objectid, const char *path_name)
{
int ret;
u64 sectorsize = root->sectorsize;
char *buf = malloc(sectorsize);
char buf[PATH_MAX];
ret = readlink(path_name, buf, sectorsize);
ret = readlink(path_name, buf, sizeof(buf));
if (ret <= 0) {
fprintf(stderr, "readlink failed for %s\n", path_name);
goto fail;
}
if (ret >= sectorsize) {
if (ret >= sizeof(buf)) {
fprintf(stderr, "symlink too long for %s\n", path_name);
ret = -1;
goto fail;
@ -609,7 +608,6 @@ static int add_symbolic_link(struct btrfs_trans_handle *trans,
ret = btrfs_insert_inline_extent(trans, root, objectid, 0,
buf, ret + 1);
fail:
free(buf);
return ret;
}