From 1643179c6a7f5a7af1dc674934900ea30972c9dd Mon Sep 17 00:00:00 2001 From: Jeff Mahoney Date: Tue, 13 Aug 2019 21:03:58 -0400 Subject: [PATCH] btrfs-progs: mkfs: treat btrfs_add_to_fsid as fatal error When btrfs_add_to_fsid fails in mkfs we try to close the ctree. That complains that we already have a transaction open. We should be taking the error path and exit cleanly without writing. Reviewed-by: Qu Wenruo Signed-off-by: Jeff Mahoney Signed-off-by: David Sterba --- mkfs/main.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/mkfs/main.c b/mkfs/main.c index 971cb395..b752da13 100644 --- a/mkfs/main.c +++ b/mkfs/main.c @@ -1268,7 +1268,7 @@ int BOX_MAIN(mkfs)(int argc, char **argv) sectorsize, sectorsize, sectorsize); if (ret) { error("unable to add %s to filesystem: %d", file, ret); - goto out; + goto error; } if (verbose >= 2) { struct btrfs_device *device;